1319494 - Consider converting testBrowserDatabaseHelperUpgrades into a junit4 test

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Testing, defect, P3)

Description

[Andrzej Hunt :ahunt]

Our DB upgrade test is currently a robocop test. Robocop tests can be somewhat unreliable, and can intermittently fail for no obvious reason (that often has no relation to the code actually being tested). See bugs 1269651 and 1317043.

The test was originally built as a robocop test, with the reasoning that:
- junit 3 tests (which run on-device) aren't run in automation -> no value in using these
- Roboelectric junit4 tests might not use an appropriate DB version.

I've investigated a little, and it looks like roboelectric uses a DB corresponding to the current minSdkVersion (i.e. a 3.7.10 DB, which is the sqlite version used in API 15). Hence we'd still obtain the full value of such tests if running in roboelectric. We only run robocop tests on 4.3 in automation, so we don't lose any platforms by switching.

I'm adding some DB-opening tests in Bug 1319485, I'd recommend looking at those patches to see how to open DB files in our junit4 tests.

Note: sqlite is forward compatible only within a 3.N release series. I.e. any DB created on a device running sqlite 3.7.X (i.e. Android < 5) is usable, anything newer can't be used to provide a testable DB since 3.7.X can't open 3.8.X or newer DBs.

Comment 1

[Geoff Brown [:gbrown]]

Mass closing Firefox for Android :: Testing bugs with no progress in 2017.

If this bug is important to you, please re-open.