1319543 - ogg file no longer playing in firefox 50

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[[:philipp]]

we got a report at sumo by a user that after the update to firefox 50 certain .ogg files do no longer play, one sample url that was given was https://s3-sa-east-1.amazonaws.com/ell-random-sharing/st_294_1.ogg

this problem is reproducible and in the web console i get the error: "Media resource https://s3-sa-east-1.amazonaws.com/ell-random-sharing/st_294_1.ogg could not be decoded."

when looking for the regression range of the issue with mozrgression i ended up with https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=786521deead2bb8607d806ed77562baf4783b318&tochange=de5f049f1029d88385fadb9a57a0d64ae78a1332 & bug 1288329.

Comment 1

[Jean-Yves Avenard [:jya]]

from about:media

From about:media:

currentTime: 12.516 readyState: 1 error: 3 (0x806e0007: DoDecode: Overflow adding total_duration and aTstampUsecs)

Comment 2

[Jean-Yves Avenard [:jya]]

the first sample has a negative time... this makes the file non-spec compliant.

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1319543: Prevent overflow if sample's time is negative.

Review commit: https://reviewboard.mozilla.org/r/94854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94854/

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8813452 [details]
Bug 1319543: Prevent overflow if sample's time is negative.

https://reviewboard.mozilla.org/r/94854/#review95078

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e36c1367ba2
Prevent overflow if sample's time is negative. r=gerald

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3e36c1367ba2

Comment 7

[Jean-Yves Avenard [:jya]]

Comment on attachment 8813452 [details]
Bug 1319543: Prevent overflow if sample's time is negative.

Approval Request Comment
[Feature/regressing bug #]: 1288329
[User impact if declined]: Some file with vorbis will no longer play (not just ogg as the bug title suggest, it can impact webm used by youtube too)
[Describe test coverage new/current, TreeHerder]: in central
[Risks and why]: Low, it was an incorrect cast between signed / unsigned
[String/UUID change made/needed]: None

Would be nice to have that in the point release too.

Comment 8

[Gerry Chang [:gchang]]

Hi :philipp,
could you help verify if this issue is fixed as expected on the latest Nightly build? Thanks!

Comment 9

[Julien Cristau [:jcristau]]

confirmed that the file from comment #0 doesn't play with yesterday's nightly and plays with today's

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 8813452 [details]
Bug 1319543: Prevent overflow if sample's time is negative.

fix signedness confusion in vorbis decoder, aurora52+

Comment 11

[Gerry Chang [:gchang]]

Comment on attachment 8813452 [details]
Bug 1319543: Prevent overflow if sample's time is negative.

Fix a regression related to ogg file and was verified. Beta51+. Should be in 51 beta 4.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c5c00b463cc7

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cd9c48229ba3

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8813452 [details]
Bug 1319543: Prevent overflow if sample's time is negative.

Fix has been verified on pre-release, new regression in 50, meets the bar for 50.1.0

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-release/rev/afeaa0e22345000f0bc22a991e511e9c3513d12e