Closed Bug 1319557 Opened 3 years ago Closed 3 years ago

Dev crash when GPU process before SyncObjectD3D11 is opened

Categories

(Core :: Graphics: Layers, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: dvander, Assigned: dvander)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

If the GPU process crashes in the middle of the first transaction, a Nightly/Aurora browser can crash because the sync object handle was never opened (and therefore no longer exists). Easiest thing is to just demote this crash, but I'd also like to open this handle as soon as we getit.

Dev Crash: http://searchfox.org/mozilla-central/rev/59bb309e38b10aba63dea8505fb800e99fe821d6/gfx/layers/d3d11/TextureD3D11.cpp#1227

Example job: https://treeherder.mozilla.org/#/jobs?repo=try&author=danderson@mozilla.com&selectedJob=31622247
Priority: -- → P3
Whiteboard: [gfx-noted]
Attached patch bug1319557.patchSplinter Review
This refactors SyncObjectD3D11.cpp a little so that FinalizeFrame is split into two methods. Then the gfxDevCrash assert is relaxed to not include the GPU process.

(Maybe we should separate the telemetry and crashiness of this, but this key has 0 hits in our current Telemetry anyway.)
Attachment #8813864 - Flags: review?(matt.woodrow)
Attachment #8813864 - Flags: review?(matt.woodrow) → review+
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2259891dc1e8
Clean up and relax some assertions in SyncObjectD3D11.cpp. (bug 1319557, r=mattwoodrow)
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28e269b5ab12
Clean up and relax some assertions in SyncObjectD3D11.cpp. (bug 1319557, r=mattwoodrow)
https://hg.mozilla.org/mozilla-central/rev/28e269b5ab12
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Flags: needinfo?(dvander)
See Also: → 1345735
You need to log in before you can comment on or make changes to this bug.