Dev crash when GPU process before SyncObjectD3D11 is opened

RESOLVED FIXED in Firefox 53

Status

()

Core
Graphics: Layers
P3
normal
RESOLVED FIXED
a year ago
8 months ago

People

(Reporter: dvander, Assigned: dvander)

Tracking

(Blocks: 1 bug)

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

(Assignee)

Description

a year ago
If the GPU process crashes in the middle of the first transaction, a Nightly/Aurora browser can crash because the sync object handle was never opened (and therefore no longer exists). Easiest thing is to just demote this crash, but I'd also like to open this handle as soon as we getit.

Dev Crash: http://searchfox.org/mozilla-central/rev/59bb309e38b10aba63dea8505fb800e99fe821d6/gfx/layers/d3d11/TextureD3D11.cpp#1227

Example job: https://treeherder.mozilla.org/#/jobs?repo=try&author=danderson@mozilla.com&selectedJob=31622247
Priority: -- → P3
Whiteboard: [gfx-noted]
(Assignee)

Comment 1

a year ago
Created attachment 8813864 [details] [diff] [review]
bug1319557.patch

This refactors SyncObjectD3D11.cpp a little so that FinalizeFrame is split into two methods. Then the gfxDevCrash assert is relaxed to not include the GPU process.

(Maybe we should separate the telemetry and crashiness of this, but this key has 0 hits in our current Telemetry anyway.)
Attachment #8813864 - Flags: review?(matt.woodrow)
Attachment #8813864 - Flags: review?(matt.woodrow) → review+

Comment 2

a year ago
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2259891dc1e8
Clean up and relax some assertions in SyncObjectD3D11.cpp. (bug 1319557, r=mattwoodrow)
I had to back this out for build failures like https://treeherder.mozilla.org/logviewer.html#?job_id=39950811&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/670fef2c9a617f21f3e273a2d558be356da431d0
Flags: needinfo?(dvander)

Comment 4

a year ago
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28e269b5ab12
Clean up and relax some assertions in SyncObjectD3D11.cpp. (bug 1319557, r=mattwoodrow)

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/28e269b5ab12
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
(Assignee)

Updated

11 months ago
Flags: needinfo?(dvander)

Updated

8 months ago
See Also: → bug 1345735
You need to log in before you can comment on or make changes to this bug.