1319563 - Move command-line generation to the CommonBackend

Status: RESOLVED DUPLICATE of bug 1362612

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

There is a lot of logic for generating compiler commandlines in CompileDB, but it would be useful to share that among all backends.

Comment 1

[Mike Hommey [:glandium]]

FWIW, I didn't want to do that because it's all mostly hacks. Instead, I'd rather add the right things to the common backend and/or emitter/elsewhere so that we don't need hacks.

Comment 2

[Michael Shal [:mshal]]

Can you clarify what the right things would be? IMO the hacky bits are the Makefile-looking variable references that get expanded, though most of them can be just replaced in-line with the final values when the object is consumed. I think the only exception I found was LIBRARY_DEFINES, which needs to be propagated by the emitter first.

In any case I think it would be helpful to find a way to share what we have, and then make it better.

Comment 3

[Michael Shal [:mshal]]

Attachment: Bug 1319563 - Move CompileDBBackend:_build_db_line to CommonBackend:_build_compiler_line;

Review commit: https://reviewboard.mozilla.org/r/95208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95208/

Comment 4

[Michael Shal [:mshal]]

Attachment: Bug 1319563 - Move command line generation to the CommonBackend;

Review commit: https://reviewboard.mozilla.org/r/95210/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95210/

Comment 5

[Michael Shal [:mshal]]

Attachment: Bug 1319563 - Provide actual output filenames in compiler command-lines;

Review commit: https://reviewboard.mozilla.org/r/95212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95212/

Comment 6

[Michael Shal [:mshal]]

The first two patches should be no-ops as far as CompileDB is concerned. The last one just adds output filenames instead of using /dev/null - I'm not sure if that has unintended consequences.

This at least lets me get compiler command-lines usable by the tup backend.

Comment 7

[Mike Hommey [:glandium]]

If we're going to go with the hacky approach of reusing this, I'd prefer if it went in a new intermediate class rather than CommonBackend.

Comment 8

[Chris Manchester (limited bugmail, email directly)]

mshal and I discussed this, there's not much use for this after bug 1362612