1319614 - stylo: Move Servo Arc types to a list file to reduce code duplication

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

With bug 1307357 landed, now we have five Servo arc types, and with the progress of CSSOM support, more such types will be added.

Currently adding such a type needs adding code in five different places among three different files. And forgetting to do so sometimes leads to build failures which is only shown in non-stylo builds (which means you may not be aware until pushing to the server).

It would be easier to manage if we have a file listing all arc types, and use the list in those places.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1319614 - Move Servo Arc types to a list file.

Review commit: https://reviewboard.mozilla.org/r/94866/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94866/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

After having this, we can make the regen script (and in the future, the build script) parse this list file for arc types directly.

Comment 3

[Bobby Holley (:bholley)]

Seems fine, but let's have Manish look it over since he's done more work on the FFI layer recently than I have.

Comment 4

[Manish Goregaokar [:manishearth]]

Comment on attachment 8813461 [details]
Bug 1319614 - Move Servo Arc types to a list file.

https://reviewboard.mozilla.org/r/94866/#review95726

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a74bd474c1a6
Move Servo Arc types to a list file. r=manishearth

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a74bd474c1a6