Closed Bug 1319614 Opened 3 years ago Closed 3 years ago

stylo: Move Servo Arc types to a list file to reduce code duplication

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

With bug 1307357 landed, now we have five Servo arc types, and with the progress of CSSOM support, more such types will be added.

Currently adding such a type needs adding code in five different places among three different files. And forgetting to do so sometimes leads to build failures which is only shown in non-stylo builds (which means you may not be aware until pushing to the server).

It would be easier to manage if we have a file listing all arc types, and use the list in those places.
Blocks: 1315601
After having this, we can make the regen script (and in the future, the build script) parse this list file for arc types directly.
Attachment #8813461 - Flags: review?(bobbyholley) → review?(manishearth)
Seems fine, but let's have Manish look it over since he's done more work on the FFI layer recently than I have.
Comment on attachment 8813461 [details]
Bug 1319614 - Move Servo Arc types to a list file.

https://reviewboard.mozilla.org/r/94866/#review95726
Attachment #8813461 - Flags: review?(manishearth) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a74bd474c1a6
Move Servo Arc types to a list file. r=manishearth
https://hg.mozilla.org/mozilla-central/rev/a74bd474c1a6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.