1319629 - Introduce Narrate in Fennec

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Eitan Isaacson [:eeejay]]

Narrate would be a great addition to a mobile browser, allowing articles to be read on the go.

I have a WIP. Unfortunately, I don't think the current UI lends to a good mobile experience.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1319629 - Move components/translation from browser to toolkit.

Review commit: https://reviewboard.mozilla.org/r/94912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94912/

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1319629 - Add Narrate to Android (WIP).

Review commit: https://reviewboard.mozilla.org/r/94914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94914/

Comment 3

[Eitan Isaacson [:eeejay]]

Anthony,

Can you give some guidance as to how you think Narrate should look/work in mobile?

I triggered a try build that should give you an APK to play with. Right now it is a pretty direct port from Desktop.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Hey Eitan!

Thanks for the ping! I'm going to CC Barbara (Product) here as well so that we can prioritize this against the rest of the plans for the product. 

Is there an APK I can try somewhere?

Comment 5

[Eitan Isaacson [:eeejay]]

(In reply to Anthony Lam (:antlam) from comment #4)
> Hey Eitan!
> 
> Thanks for the ping! I'm going to CC Barbara (Product) here as well so that
> we can prioritize this against the rest of the plans for the product. 
> 
> Is there an APK I can try somewhere?

Here you go!
https://archive.mozilla.org/pub/mobile/try-builds/[e-mail]-76d3a9c3a12ee61e81d8c7f734f84ec90005fdc8/try-android-api-15/fennec-53.0a1.en-US.android-arm.apk

Comment 6

[Eitan Isaacson [:eeejay]]

Bah, I forgot to have a few prefs preset. You need to toggle these two to 'true' in about:config:
- narrate.enabled
- media.webspeech.synth.enabled

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Please measure any apk size impact here.

Comment 8

[Eitan Isaacson [:eeejay]]

Comment on attachment 8813493 [details]
Bug 1319629 - Move components/translation from browser to toolkit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/94912/diff/1-2/

Comment 9

[Eitan Isaacson [:eeejay]]

Comment on attachment 8813494 [details]
Bug 1319629 - Add Narrate to Android (WIP).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/94914/diff/1-2/

Comment 10

[Eitan Isaacson [:eeejay]]

Here is an updated APK with preset prefs:
https://archive.mozilla.org/pub/mobile/try-builds/[e-mail]-c3b22789481929d0543bc8cb8e6c1b1adba1fa18/try-android-api-15/fennec-53.0a1.en-US.android-arm.apk

Comment 11

[Eitan Isaacson [:eeejay]]

Hey Anthony,

Just got back from leave. Above is an APK you can try out. Thanks!

Comment 12

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Thanks Eitan! I'm also going to add Product on this for their input.

cheers!

Comment 13

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Eitan Isaacson [:eeejay] from comment #10)
> Here is an updated APK with preset prefs:
> https://archive.mozilla.org/pub/mobile/try-builds/[e-mail]-
> c3b22789481929d0543bc8cb8e6c1b1adba1fa18/try-android-api-15/fennec-53.0a1.en-
> US.android-arm.apk

I'm also seeing a 404 Not Found error on this link... :(

Comment 14

[Barbara Bermes [:barbara] - NI please!]

Awesome, Eitan. Thanks.

I'm also getting a 404 on this.

In addition, I've put it in our backlog for consideration. https://trello.com/b/a47BZyic/fennec-core

Adding Joe who most likely will take care of that.

My first take on it, we should evaluate how much UX is involved and compare it to other priorities that UX is working on.

I believe the Desktop version of this feature got a lot of attention and I could even see this being even more valuable for Mobile (i.e on the go) plus of course the accessibility aspect in general.

Comment 15

[Eitan Isaacson [:eeejay]]

Here's a new link!

https://archive.mozilla.org/pub/mobile/try-builds/[e-mail]-dec827dc54c3b111bb9d310a20973fbe2142354d/try-android-api-15/fennec-53.0a1.en-US.android-arm.apk

Comment 16

[Joe Cheng [:jcheng] (please needinfo)]

I just downloaded the apk but how can I test it out?

Comment 17

[Barbara Bermes [:barbara] - NI please!]

I'm getting a corrupted APK message.

Comment 18

[Eitan Isaacson [:eeejay]]

Attachment: screen.png

Just tried and the APK works for me. Here are some instructions for trying (apologize if you already tried this).

1. In Settings under "Security" make sure "Unknown sources" is enabled.
2. Download the APK to your phone.
3. Open it. You should get an install dialog. Click through it.
4. Once installed, open the "Nightly" app. This should be the experimental build I offered here.
5. Navigate to any random wikipedia article. Here is an example: https://en.m.wikipedia.org/wiki/Porosity
6. Enable reader mode by tapping on the book in the right of the address bar.
7. You should get a sanitized version of the page. Next to the orange font button in the lower right should be another orange button. This is the narrate feature! I attached a screenshot of what that looks like.

Comment 19

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

clearing NI for now as we prioritize this :)

Comment 20

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.