Closed
Bug 1319741
Opened 8 years ago
Closed 8 years ago
Convert some code in hal/ to C++11
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: andi, Assigned: andi)
References
Details
Attachments
(1 file)
Using the checkers provided by clang-tidy we can refresh the code to make it use the features of C++11 like:
- auto variables declarations
- default CTORS and DTORS
- using new range loop operators
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Attachment #8813617 -
Flags: review?(gsvelto)
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8813617 [details]
Bug 1319741 - Use C++11's override and remove virtual where applicable in hal/.
https://reviewboard.mozilla.org/r/95048/#review95204
LGTM, thanks!
Attachment #8813617 -
Flags: review?(gsvelto) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6bafacee658
Use C++11's override and remove virtual where applicable in hal/. r=gsvelto
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•