1319752 - Convert some code in startupcache/ to C++11

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Andi [:andi]]

Using the checkers provided by clang-tidy we can refresh the code to make it use the features of C++11 like:

- auto variables declarations
- default CTORS and DTORS
- using new range loop operators

Comment 1

[Andi [:andi]]

Attachment: Bug 1319752 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in startupcache/.

Review commit: https://reviewboard.mozilla.org/r/95058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95058/

Comment 2

[Andi [:andi]]

Attachment: Bug 1319752 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in startupcache/.

Review commit: https://reviewboard.mozilla.org/r/95060/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95060/

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8813629 [details]
Bug 1319752 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in startupcache/.

https://reviewboard.mozilla.org/r/95058/#review95208

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8813630 [details]
Bug 1319752 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in startupcache/.

https://reviewboard.mozilla.org/r/95060/#review95210

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a7511f0ab14
Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in startupcache/. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/955818a2e3b1
Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in startupcache/. r=froydnj

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7a7511f0ab14
https://hg.mozilla.org/mozilla-central/rev/955818a2e3b1