Closed Bug 1319752 Opened 3 years ago Closed 3 years ago

Convert some code in startupcache/ to C++11

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: andi, Assigned: andi)

References

Details

Attachments

(2 files)

Using the checkers provided by clang-tidy we can refresh the code to make it use the features of C++11 like:

- auto variables declarations
- default CTORS and DTORS
- using new range loop operators
Attachment #8813629 - Flags: review?(nfroyd)
Attachment #8813630 - Flags: review?(nfroyd)
Comment on attachment 8813629 [details]
Bug 1319752 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in startupcache/.

https://reviewboard.mozilla.org/r/95058/#review95208
Attachment #8813629 - Flags: review?(nfroyd) → review+
Comment on attachment 8813630 [details]
Bug 1319752 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in startupcache/.

https://reviewboard.mozilla.org/r/95060/#review95210
Attachment #8813630 - Flags: review?(nfroyd) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a7511f0ab14
Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in startupcache/. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/955818a2e3b1
Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in startupcache/. r=froydnj
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.