Closed
Bug 1319752
Opened 8 years ago
Closed 8 years ago
Convert some code in startupcache/ to C++11
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: andi, Assigned: andi)
References
Details
Attachments
(2 files)
Using the checkers provided by clang-tidy we can refresh the code to make it use the features of C++11 like: - auto variables declarations - default CTORS and DTORS - using new range loop operators
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Attachment #8813629 -
Flags: review?(nfroyd)
Attachment #8813630 -
Flags: review?(nfroyd)
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8813629 [details] Bug 1319752 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in startupcache/. https://reviewboard.mozilla.org/r/95058/#review95208
Attachment #8813629 -
Flags: review?(nfroyd) → review+
|
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8813630 [details] Bug 1319752 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in startupcache/. https://reviewboard.mozilla.org/r/95060/#review95210
Attachment #8813630 -
Flags: review?(nfroyd) → review+
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7a7511f0ab14 Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in startupcache/. r=froydnj https://hg.mozilla.org/integration/autoland/rev/955818a2e3b1 Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in startupcache/. r=froydnj
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7a7511f0ab14 https://hg.mozilla.org/mozilla-central/rev/955818a2e3b1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•