Closed Bug 1319829 Opened 8 years ago Closed 8 years ago

migration module should take locale instead of language code

Categories

(L20n :: Python Library, defect)

Product:
L20n
Component:
Python Library
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Pike, Assigned: stas)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Pull request
43 bytes, text/x-github-pull-request
Pike
: review+
Details | Review 
Right now, the migration code takes a language code. It's use-case is to get the plural rule categories from cldr, which are defined for some combination of language and region tags.

We should make the conversion between the locale code we have and what cldr knows about inside cldr.py.

We should fix that before we land the migration mach command in bug 1315005.
Do you think we should run some kind of a language negotiation here, or just hard-code the mapping from codes used at Mozilla to codes known by CLDR?
I'd fallback in the sense of ja-JP-mac -> ja-JP -> ja. Nothing fancier than that.

I think that's easier than hard-coding 20+ entries.
Attached file Pull request — 
Assignee: nobody → stas
Status: NEW → ASSIGNED

        Attachment #8814464 -
        Flags: review?(l10n)

    
    

    
  
Comment on attachment 8814464 [details] [review]
Pull request

r=me

        Attachment #8814464 -
        Flags: review?(l10n) → review+

    
    

    
  
Thanks!

https://github.com/l20n/python-l20n/commit/25de7bf878df5f123a86448d333eb70cb16d225f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: