Closed Bug 1319936 Opened 3 years ago Closed 3 years ago

Remove String generics uses in dom/encoding

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: anba, Assigned: anba)

References

Details

Attachments

(1 file)

The various String generic methods are non-standard APIs and we plan to warn when they're used (bug 1319926) and eventually want to remove them completely (bug 1222552). As a first step we need to replace all String generic uses in Firefox with the counterpart from String.prototype.


In dom/encoding/test/test_TextEncoder.js, String.charCodeAt needs to be replaced with a call to String.prototype.charCodeAt.
Attached patch bug1319936.patchSplinter Review
Attachment #8814230 - Flags: review?(wmccloskey)
Attachment #8814230 - Flags: review?(wmccloskey) → review+
Thanks for reviewing!
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e6c0d61f554
Remove String generics uses in dom. r=billm
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1e6c0d61f554
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.