Closed
Bug 1319937
Opened 8 years ago
Closed 8 years ago
Remove String generics uses in services/sync
Categories
(Firefox :: Sync, defect, P1)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(1 file)
|
1.33 KB,
patch
|
markh
:
review+
|
Details | Diff | Splinter Review |
The various String generic methods are non-standard APIs and we plan to warn when they're used (bug 1319926) and eventually want to remove them completely (bug 1222552). As a first step we need to replace all String generic uses in Firefox with the counterpart from String.prototype. In services/sync/tests/unit/test_bookmark_validator.js, String.localeCompare needs to be replaced with a call to String.prototype.localeCompare.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8814231 -
Flags: review?(markh)
|
||
Updated•8 years ago
|
Attachment #8814231 -
Flags: review?(markh) → review+
|
||
Updated•8 years ago
|
Priority: -- → P1
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2a34ba3cdc1d Remove String generics uses in services/sync. r=markh
Keywords: checkin-needed
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2a34ba3cdc1d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in
before you can comment on or make changes to this bug.
Description
•