1320010 - Inspector sidebar is broken when devtools.layoutview.enabled is set to true

Status: VERIFIED FIXED

Description

[Sebastian Zartner [:sebo]]

When the preference devtools.layoutview.enabled is set to true the Inspector sidebar can't be opened anymore.

The Browser Console shows the following related errors:

fileName:"resource://devtools/client/shared/browser-loader.js"
lineNumber:125
message:"Module `resource://devtools/client/inspector/layout/components/app.js` is not found at resource://devtools/client/inspector/layout/components/app.js"

TypeError: sidePaneContainer is null[Learn More] inspector.js:1378:11

Sebastian

Comment 1

[Sebastian Zartner [:sebo]]

mozregression spit out bug 1314931.

Related regression range was:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=95f2069670c668c07e984d225d1829b017212db3&tochange=3d032c10f6cc6d16ee04533ea7a218bf1ec4491d

Sebastian

Comment 2

[Patrick Brosset <:pbro>]

CC'ing Gabriel as this is something we might want to get to rather quickly.
Thanks Sebastian for filing.

Comment 3

[Gabriel [:gl] (ΦωΦ)]

Created attachment 8813999 [details] [diff] [review]
1320010.patch

Surprised this didn't report an error on MacOSX and continued to work. This should fix it.

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8813999 [details] [diff] [review]
1320010.patch

Review of attachment 8813999 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the quick fix! Mind logging a follow up to add a test?

> Surprised this didn't report an error on MacOSX and continued to work.

From what I tested, it works on a local build on OSX, but fails on a Nightly build.
This might be coming from the fact that local builds use symlinks for some files instead of really packaging them.
Which means they benefit of the case insensitive file system used on OSX.

Comment 5

[Gabriel [:gl] (ΦωΦ)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e13ca676d63607f1a19a73c77b7331253d0e2ba8
Bug 1320010 - Fix incorrect file reference to devtools/inspector/client/layout/components/App. r=jdescottes

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e13ca676d636

Comment 7

[Sebastian Zartner [:sebo]]

Thank you for the very fast fix! I think this should be backported to 52.

Sebastian

Comment 8

[Gabriel [:gl] (ΦωΦ)]

Comment on attachment 8813999 [details] [diff] [review]
1320010.patch

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Inspector won't open.
[Describe test coverage new/current, TreeHerder]: None, because it is a path fix.
[Risks and why]: 
[String/UUID change made/needed]:

Comment 9

[Patrick Brosset <:pbro>]

It helps people taking the decision to uplift this if they are given a bit more information about the request. So let me add a few more details:
> Approval Request Comment
> [Feature/regressing bug #]: bug 1314931
> [User impact if declined]: If the pref devtools.layoutview.enabled is set to true (it is false by default), then the Inspector panel in DevTools won't open.
> [Describe test coverage new/current, TreeHerder]: None, because it is a path fix.
> [Risks and why]: The risk is very limited, and the code changed here doesn't impact Firefox, only DevTools, and only when the pref devtools.layoutview.enabled is set to true.
> [String/UUID change made/needed]: None

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 8813999 [details] [diff] [review]
1320010.patch

devtools fix for osx, take in aurora52

Thanks for clarifying the uplift request, Patrick!

Comment 11

[Nawaf Chowdhury Akash]

I've seen this issue on this bug in nightly 53.0a1 (2016-11-23) from windows 10, 64 bit.

This bug is verified now as fixed on latest nightly 53.0a1 .

Build Id :(20161127030208)

User agent : (Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0)

Comment 12

[Carsten Book [:Tomcat]]

needs rebasing for aurora

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f3a55c57f637

Comment 14

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 53.0a1 (2016-11-23) (64-bit)  on Windows 7, 64 Bit !

This bug's fix is verified with latest Aurora

Build ID    20161130004019
User Agent  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
 [bugday-20161130]