If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Destroy WebRenderBridgeChild in CompositorBridgeChild::Destroy()

RESOLVED FIXED in mozilla54

Status

()

Core
Graphics: WebRender
RESOLVED FIXED
10 months ago
7 months ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

(Blocks: 1 bug)

unspecified
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

10 months ago
WebRenderBridgeChild should be destroyed in  CompositorBridgeChild::Destroy() like LayerTransactionChild.
(Assignee)

Updated

10 months ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Updated

10 months ago
Blocks: 1311790, 1319188
(Assignee)

Comment 1

10 months ago
Created attachment 8814009 [details] [diff] [review]
patch -  Make WebRenderBridgeChild destroy simiar to LayerTransactionChild
(Assignee)

Updated

10 months ago
Attachment #8814009 - Flags: review?(nical.bugzilla)

Updated

10 months ago
Attachment #8814009 - Flags: review?(nical.bugzilla) → review+

Comment 2

10 months ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/8ecafae107fb
Make WebRenderBridgeChild destroy simiar to LayerTransactionChild r=nical
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED

Comment 3

10 months ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/2a9608132a80
Fix warnings r=nical?
Comment on attachment 8814009 [details] [diff] [review]
patch -  Make WebRenderBridgeChild destroy simiar to LayerTransactionChild

Review of attachment 8814009 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/CompositorBridgeChild.cpp
@@ +144,5 @@
>        static_cast<LayerTransactionChild*>(transactions[i]);
>      layers->Destroy();
>    }
>  
> +#ifdef MOZ_ENABLE_WEBRENDER

I don't think you need to wrap things like this in the ifdef. I'd like to keep the ifdefs to a minimum, just for the rust library and things that interface directly with the rust library.
(Assignee)

Updated

9 months ago
Flags: needinfo?(sotaro.ikeda.g)
(Assignee)

Comment 5

9 months ago
Created attachment 8818433 [details] [diff] [review]
patch - Reduce MOZ_ENABLE_WEBRENDER
Flags: needinfo?(sotaro.ikeda.g)
(Assignee)

Comment 6

9 months ago
Created attachment 8818446 [details] [diff] [review]
patch - Reduce MOZ_ENABLE_WEBRENDER
Attachment #8818433 - Attachment is obsolete: true

Comment 7

9 months ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/2299de9e58d7
Reduce MOZ_ENABLE_WEBRENDER r=nical?
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.