1320023 - Destroy WebRenderBridgeChild in CompositorBridgeChild::Destroy()

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

WebRenderBridgeChild should be destroyed in  CompositorBridgeChild::Destroy() like LayerTransactionChild.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Make WebRenderBridgeChild destroy simiar to LayerTransactionChild

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/8ecafae107fb
Make WebRenderBridgeChild destroy simiar to LayerTransactionChild r=nical

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/2a9608132a80
Fix warnings r=nical?

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8814009 [details] [diff] [review]
patch -  Make WebRenderBridgeChild destroy simiar to LayerTransactionChild

Review of attachment 8814009 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/CompositorBridgeChild.cpp
@@ +144,5 @@
>        static_cast<LayerTransactionChild*>(transactions[i]);
>      layers->Destroy();
>    }
>  
> +#ifdef MOZ_ENABLE_WEBRENDER

I don't think you need to wrap things like this in the ifdef. I'd like to keep the ifdefs to a minimum, just for the rust library and things that interface directly with the rust library.

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Reduce MOZ_ENABLE_WEBRENDER

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Reduce MOZ_ENABLE_WEBRENDER

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/2299de9e58d7
Reduce MOZ_ENABLE_WEBRENDER r=nical?