Closed
Bug 1320023
Opened 7 years ago
Closed 7 years ago
Destroy WebRenderBridgeChild in CompositorBridgeChild::Destroy()
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(2 files, 1 obsolete file)
9.62 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
2.19 KB,
patch
|
Details | Diff | Splinter Review |
WebRenderBridgeChild should be destroyed in CompositorBridgeChild::Destroy() like LayerTransactionChild.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8814009 -
Flags: review?(nical.bugzilla)
Updated•7 years ago
|
Attachment #8814009 -
Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/8ecafae107fb Make WebRenderBridgeChild destroy simiar to LayerTransactionChild r=nical
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/2a9608132a80 Fix warnings r=nical?
Comment 4•7 years ago
|
||
Comment on attachment 8814009 [details] [diff] [review] patch - Make WebRenderBridgeChild destroy simiar to LayerTransactionChild Review of attachment 8814009 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/ipc/CompositorBridgeChild.cpp @@ +144,5 @@ > static_cast<LayerTransactionChild*>(transactions[i]); > layers->Destroy(); > } > > +#ifdef MOZ_ENABLE_WEBRENDER I don't think you need to wrap things like this in the ifdef. I'd like to keep the ifdefs to a minimum, just for the rust library and things that interface directly with the rust library.
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(sotaro.ikeda.g)
Assignee | ||
Comment 5•7 years ago
|
||
Flags: needinfo?(sotaro.ikeda.g)
Assignee | ||
Comment 6•7 years ago
|
||
Attachment #8818433 -
Attachment is obsolete: true
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/2299de9e58d7 Reduce MOZ_ENABLE_WEBRENDER r=nical?
Updated•7 years ago
|
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•