Closed Bug 1320023 Opened 7 years ago Closed 7 years ago

Destroy WebRenderBridgeChild in CompositorBridgeChild::Destroy()

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(2 files, 1 obsolete file)

WebRenderBridgeChild should be destroyed in  CompositorBridgeChild::Destroy() like LayerTransactionChild.
Assignee: nobody → sotaro.ikeda.g
Attachment #8814009 - Flags: review?(nical.bugzilla)
Attachment #8814009 - Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/8ecafae107fb
Make WebRenderBridgeChild destroy simiar to LayerTransactionChild r=nical
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment on attachment 8814009 [details] [diff] [review]
patch -  Make WebRenderBridgeChild destroy simiar to LayerTransactionChild

Review of attachment 8814009 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/CompositorBridgeChild.cpp
@@ +144,5 @@
>        static_cast<LayerTransactionChild*>(transactions[i]);
>      layers->Destroy();
>    }
>  
> +#ifdef MOZ_ENABLE_WEBRENDER

I don't think you need to wrap things like this in the ifdef. I'd like to keep the ifdefs to a minimum, just for the rust library and things that interface directly with the rust library.
Flags: needinfo?(sotaro.ikeda.g)
Flags: needinfo?(sotaro.ikeda.g)
Attachment #8818433 - Attachment is obsolete: true
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/2299de9e58d7
Reduce MOZ_ENABLE_WEBRENDER r=nical?
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: