Support 'tenc' box for rust mp4 parser

RESOLVED FIXED in Firefox 53

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: alfredo, Assigned: alfredo)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Updated

2 years ago
Blocks: 1161350
(Assignee)

Updated

2 years ago
See Also: → bug 1313556
(Assignee)

Updated

2 years ago
Assignee: nobody → ayang
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8817959 [details]
Bug 1320026 - support crypto info in rust mp4 parser.

https://reviewboard.mozilla.org/r/98144/#review98478

::: media/libstagefright/binding/DecoderData.cpp:197
(Diff revision 1)
>  #ifdef MOZ_RUST_MP4PARSE
> +static void
> +UpdateTrackProtectedInfo(mozilla::TrackInfo& aConfig,
> +                         const mp4parser_sinf_info& aSinf)
> +{
> +  if (!!aSinf.is_encrypted) {

!= 0 is clearer in this case, I think

::: media/libstagefright/binding/MP4Metadata.cpp:307
(Diff revision 1)
>        MOZ_DIAGNOSTIC_ASSERT(audioRust->mRate == audio->mRate);
>        MOZ_DIAGNOSTIC_ASSERT(audioRust->mChannels == audio->mChannels);
>        MOZ_DIAGNOSTIC_ASSERT(audioRust->mBitDepth == audio->mBitDepth);
>        // TODO: These fields aren't implemented in the Rust demuxer yet.
>        //MOZ_DIAGNOSTIC_ASSERT(audioRust->mProfile != audio->mProfile);
> -      //MOZ_DIAGNOSTIC_ASSERT(audioRust->mExtendedProfile != audio->mExtendedProfile);
> +      MOZ_DIAGNOSTIC_ASSERT(audioRust->mExtendedProfile != audio->mExtendedProfile);

Oops, this should be ==, please fix the commented bit above too
Attachment #8817959 - Flags: review?(kinetik) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 5

2 years ago
this also needs this PR.

https://github.com/mozilla/mp4parse-rust/pull/49
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 8

2 years ago
Pushed by ayang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3664eb1f7737
support crypto info in rust mp4 parser. r=kinetik

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3664eb1f7737
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.