1320032 - Assertion failure: !mSize.IsEmpty(), at FrameLayerBuilder.cpp:1623

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P3)

Description

[Carsten Book [:Tomcat]]

Attachment: bughunter stack

found via bughunter and reproduced on latest windows tinderbox trunk debug build.

Steps to reproduce:
-> Load http://www.jetcost.es/Bpop.php?from=PAR&to=MAD&departure=2016-12-17&partner=brg-lastminute&provider=
--> Assertion failure: !mSize.IsEmpty(), at c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/layout/painting/FrameLayerBuilder.cpp:1623

aurora + trunk regression

Comment 1

[Carsten Book [:Tomcat]]

markus, matt: could you take a look at this ?

Comment 2

[Carsten Book [:Tomcat]]

also able to reproduce on http://trips.lastminute.com/hotel/route/search-results?businessProfileId=HOLIDAYSLASTMINUTECOUK&bf_subsource=S01HPV10S10RR01&search.rooms%5B0%5D.adults=1&COBRANDED=HOLIDAYSLASTMINUTECOUK&newpage=true&bf_source=&search.destinationCities=154485&search.departureIntervals=20161216-20161217&search.type=OSE&search.accomodationOnly=true

Comment 3

[u459114]

Attachment: Bug 1320032 - Early return if the size of mask surface will be empty.

Review commit: https://reviewboard.mozilla.org/r/99242/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99242/

Comment 4

[u459114]

Comment on attachment 8819488 [details]
Bug 1320032 - Early return if the size of mask surface will be empty.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99242/diff/1-2/

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 8819488 [details]
Bug 1320032 - Early return if the size of mask surface will be empty.

https://reviewboard.mozilla.org/r/99242/#review100616

::: layout/painting/FrameLayerBuilder.cpp:3900
(Diff revision 2)
>    int32_t maxSize = mManager->GetMaxTextureSize();
>    IntSize surfaceSize(std::min(itemRect.width, maxSize),
>                        std::min(itemRect.height, maxSize));
>  
>    if (surfaceSize.IsEmpty()) {
> +    // Early if we have known the size of this mask surface is empty.

"Return early if we know that the size of this mask surface is empty."

::: layout/painting/FrameLayerBuilder.cpp:6286
(Diff revision 2)
>    // It is the transform from the masked layer's space to mask space
>    gfx::Matrix maskTransform =
>      Matrix::Scaling(surfaceSize.width / boundingRect.Width(),
>                      surfaceSize.height / boundingRect.Height());
> +  if (surfaceSize.IsEmpty()) {
> +    // Early if we have known the size of this mask surface is empty.

same here

Comment 6

[u459114]

Comment on attachment 8819488 [details]
Bug 1320032 - Early return if the size of mask surface will be empty.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99242/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd0548c3fe1c
Early return if the size of mask surface will be empty. r=mstange

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cd0548c3fe1c

Comment 9

[Carsten Book [:Tomcat]]

needs to be uplifted to beta i guess since 52 is affected i think. What do you think c.j ?

Comment 10

[u459114]

[Tracking Requested - why for this release]:

Comment 11

[u459114]

Comment on attachment 8819488 [details]
Bug 1320032 - Early return if the size of mask surface will be empty.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1234485
[User impact if declined]: hitting assertion failure while visit a page has empty round rects. 
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: code change is minor.
[String changes made/needed]:NAN

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 8819488 [details]
Bug 1320032 - Early return if the size of mask surface will be empty.

deal gracefully with empty mask surface, beta52+

Comment 13

[Julien Cristau [:jcristau]]

Not sure this warrants tracking if its only effect is assertions in debug builds.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/471c4b0e0abd