Closed
Bug 1320049
Opened 8 years ago
Closed 8 years ago
Checkbox looks inconsistent (10 px too wide) in "Insecure Connection" warning, compared to the other Firefox checkboxes
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 53
| Tracking | Status | |
|---|---|---|
| firefox-esr45 | --- | unaffected |
| firefox50 | --- | unaffected |
| firefox51 | --- | unaffected |
| firefox52 | --- | unaffected |
| firefox53 | --- | verified |
People
(Reporter: Virtual, Assigned: dao)
References
()
Details
(Keywords: nightly-community, regression, ux-consistency)
Attachments
(3 files)
bad.png
+++ This bug was initially created as a clone of Bug #1317795 +++ [Tracking Requested - why for this release]: Regression STR: 1. Open this website page - https://forum.doom9.org/showthread.php?t=166689 2. See that checkbox is rendered differently (10 px too wide) compared to the other Firefox checkboxes
Flags: needinfo?(mconley)
|
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
|
Updated•8 years ago
|
status-firefox-esr45:
--- → unaffected
|
||
Comment 2•8 years ago
|
||
Removing the whole block here (from line 111 to 117): https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/aboutNetError.css#111 fixes the issue
|
Assignee | |
Updated•8 years ago
|
Component: General → Theme
|
|
Assignee | |
Comment 3•8 years ago
|
||
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Flags: needinfo?(mconley)
Attachment #8814368 -
Flags: review?(mconley)
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8814368 [details] [diff] [review] patch Review of attachment 8814368 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8814368 -
Flags: review?(mconley) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/46a20ea6799d Remove obsolete checkbox styling. r=mconley
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/46a20ea6799d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
|
|
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
|
Comment 7•8 years ago
|
||
Firefox 52 will be also affected per bug #1317795 comment #25 and bug #1317795 comment #27, so requesting and uplift request.
Flags: needinfo?(dao+bmo)
|
|
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
|
Updated•8 years ago
|
Status: RESOLVED → VERIFIED
|
||
Comment 8•7 years ago
|
||
With no reply from Dão in 3 weeks, maybe Mike can help? If you think this should be fixed in 52, can you request the uplift?
Flags: needinfo?(mconley)
|
|
||
Comment 9•7 years ago
|
||
With bug 1321302 landed in 52 (which effectively undoes the styling that was done to move us to proper checkboxes as opposed to pseudoelements) this bug is no longer reproducible for me, so I don't believe this uplift is necessary. Settings the flags.
Flags: needinfo?(mconley)
|
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(dao+bmo)
|
|
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
|
Updated•7 years ago
|
Keywords: nightly-community
|
|
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
|
Updated•7 years ago
|
QA Contact: Virtual
You need to log in
before you can comment on or make changes to this bug.
Description
•