1320049 - Checkbox looks inconsistent (10 px too wide) in "Insecure Connection" warning, compared to the other Firefox checkboxes

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bad.png

+++ This bug was initially created as a clone of Bug #1317795 +++

[Tracking Requested - why for this release]: Regression

STR:
1. Open this website page - https://forum.doom9.org/showthread.php?t=166689
2. See that checkbox is rendered differently (10 px too wide) compared to the other Firefox checkboxes

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: good.png

Comment 2

[Tim Nguyen :ntim]

Removing the whole block here (from line 111 to 117): https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/aboutNetError.css#111

fixes the issue

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8814368 [details] [diff] [review]
patch

Review of attachment 8814368 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46a20ea6799d
Remove obsolete checkbox styling. r=mconley

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/46a20ea6799d

Comment 7

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Firefox 52 will be also affected per bug #1317795 comment #25 and bug #1317795 comment #27,
so requesting and uplift request.

Comment 8

[Julien Cristau [:jcristau]]

With no reply from Dão in 3 weeks, maybe Mike can help?  If you think this should be fixed in 52, can you request the uplift?

Comment 9

[Mike Conley (:mconley) (:⚙️)]

With bug 1321302 landed in 52 (which effectively undoes the styling that was done to move us to proper checkboxes as opposed to pseudoelements) this bug is no longer reproducible for me, so I don't believe this uplift is necessary. Settings the flags.