1320066 - chrome://browser/skin/places/[e-mail] is packaged but not used on Mac

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Florian Quèze [:florian]]

My test in bug 1316187 reports chrome://browser/skin/places/[e-mail] as unused on Mac.

Bug 1181078 (https://hg.mozilla.org/mozilla-central/rev/061165ac1ff9) removed the reference from browser.css in in what seems to be an accident, as the lowdpi version of the file is still used on Mac, and the @2x version is still used on Windows.

Comment 1

[Marco Bonardo [:mak]]

You know what, I actually suspect the whole .autocomplete-treebody rules can go.
AFAICT they only act on the autocompletes using a treeview, and the only one doing that is the searchbar, that has its own rules like
.search-panel-tree > .autocomplete-treebody ...

The awesomebar uses the richlistbox from quite some time, and that's probably why we didn't notice a regression...
This could mean there's far more to remove than just that file.

Drew, could you please confirm my theory? I couldn't find any point where we may still be using these autocomplete-treebody rules in current AC. Though having a second look would be great.

I can probably make a patch once we are sure.

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1320066 - Remove unused rules and images for old treebased urlbar.

Review commit: https://reviewboard.mozilla.org/r/96004/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96004/

Comment 3

[Marco Bonardo [:mak]]

to answer my own question, the other treebased ac is the tags field autocomplete, it has some styling (could probably be simplified) but no icons at all.

Comment 4

[Marco Bonardo [:mak]]

there is only one add-on referencing this icon, with less than 300 users.

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 8814942 [details]
Bug 1320066 - Remove unused rules and images for old treebased urlbar.

https://reviewboard.mozilla.org/r/96004/#review96158

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b532137d0a6e
Remove unused rules and images for old treebased urlbar. r=adw

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b532137d0a6e

Comment 8

[u576612]

[bugday-20170105] Bug not verified