chrome://browser/skin/places/autocomplete-star@2x.png is packaged but not used on Mac

RESOLVED FIXED in Firefox 53

Status

()

Firefox
Address Bar
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: florian, Assigned: mak)

Tracking

unspecified
Firefox 53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [fxsearch])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
My test in bug 1316187 reports chrome://browser/skin/places/autocomplete-star@2x.png as unused on Mac.

Bug 1181078 (https://hg.mozilla.org/mozilla-central/rev/061165ac1ff9) removed the reference from browser.css in in what seems to be an accident, as the lowdpi version of the file is still used on Mac, and the @2x version is still used on Windows.
(Assignee)

Comment 1

2 years ago
You know what, I actually suspect the whole .autocomplete-treebody rules can go.
AFAICT they only act on the autocompletes using a treeview, and the only one doing that is the searchbar, that has its own rules like
.search-panel-tree > .autocomplete-treebody ...

The awesomebar uses the richlistbox from quite some time, and that's probably why we didn't notice a regression...
This could mean there's far more to remove than just that file.

Drew, could you please confirm my theory? I couldn't find any point where we may still be using these autocomplete-treebody rules in current AC. Though having a second look would be great.

I can probably make a patch once we are sure.
Assignee: nobody → mak77
Priority: -- → P3
Whiteboard: [fxsearch]
(Assignee)

Updated

2 years ago
Flags: needinfo?(adw)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Flags: needinfo?(adw)
(Assignee)

Comment 3

2 years ago
to answer my own question, the other treebased ac is the tags field autocomplete, it has some styling (could probably be simplified) but no icons at all.
(Assignee)

Comment 4

2 years ago
there is only one add-on referencing this icon, with less than 300 users.

Comment 5

2 years ago
mozreview-review
Comment on attachment 8814942 [details]
Bug 1320066 - Remove unused rules and images for old treebased urlbar.

https://reviewboard.mozilla.org/r/96004/#review96158
Attachment #8814942 - Flags: review?(adw) → review+

Comment 6

2 years ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/b532137d0a6e
Remove unused rules and images for old treebased urlbar. r=adw

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b532137d0a6e
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

Comment 8

2 years ago
[bugday-20170105] Bug not verified
You need to log in before you can comment on or make changes to this bug.