Closed Bug 1320094 Opened 3 years ago Closed 3 years ago

Add missing mLoading assignments in {nsHTMLFramesetFrame,nsHTMLFramesetBorderFrame}::GetCursor

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jseward, Unassigned)

References

Details

Attachments

(2 files)

Work to remove zeroing allocation in nsIPresShell (bug 1316556) uncovered
the fact that {nsHTMLFramesetFrame,nsHTMLFramesetBorderFrame}::GetCursor
don't initialise |mCursor| in their outparam |aCursor|, and they should.
Attached file Valgrind complaint
Test case = layout/generic/test/test_bug579767.html
Attached patch A simple fixSplinter Review
Attachment #8814080 - Flags: review?(dbaron)
Comment on attachment 8814080 [details] [diff] [review]
A simple fix

r=dbaron, although I still don't see how this is related to the zeroing allocation work other than showing up in the mochitest-valgrind runs you were looking at
Attachment #8814080 - Flags: review?(dbaron) → review+
(In reply to David Baron :dbaron: ⌚️UTC-8 from comment #3)
> r=dbaron, although I still don't see how this is related to the zeroing
> allocation work other than showing up in the mochitest-valgrind runs you
> were looking at

Indeed, I was just going to say that I now believe this is independent
of the zeroing allocation work, because I can see the error in runs that
don't have the patch in bug 1316556.  I think this just got picked up as 
side effect of sweeping the tree looking for 1316556-induced failures.

Detaching from 1316556 therefore.  Sorry for the confusion.
No longer blocks: 1316556
Pushed by jseward@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fbf43c56b4c
Add missing mLoading assignments in {nsHTMLFramesetFrame,nsHTMLFramesetBorderFrame}::GetCursor.  r=dbaron.
https://hg.mozilla.org/mozilla-central/rev/2fbf43c56b4c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.