1320094 - Add missing mLoading assignments in {nsHTMLFramesetFrame,nsHTMLFramesetBorderFrame}::GetCursor

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Julian Seward [:jseward]]

Work to remove zeroing allocation in nsIPresShell (bug 1316556) uncovered
the fact that {nsHTMLFramesetFrame,nsHTMLFramesetBorderFrame}::GetCursor
don't initialise |mCursor| in their outparam |aCursor|, and they should.

Comment 1

[Julian Seward [:jseward]]

Attachment: Valgrind complaint

Test case = layout/generic/test/test_bug579767.html

Comment 2

[Julian Seward [:jseward]]

Attachment: A simple fix

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8814080 [details] [diff] [review]
A simple fix

r=dbaron, although I still don't see how this is related to the zeroing allocation work other than showing up in the mochitest-valgrind runs you were looking at

Comment 4

[Julian Seward [:jseward]]

(In reply to David Baron :dbaron: ⌚️UTC-8 from comment #3)
> r=dbaron, although I still don't see how this is related to the zeroing
> allocation work other than showing up in the mochitest-valgrind runs you
> were looking at

Indeed, I was just going to say that I now believe this is independent
of the zeroing allocation work, because I can see the error in runs that
don't have the patch in bug 1316556.  I think this just got picked up as 
side effect of sweeping the tree looking for 1316556-induced failures.

Detaching from 1316556 therefore.  Sorry for the confusion.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

As I said in bug 1316556 comment 8, I believe this is a regression from https://hg.mozilla.org/mozilla-central/rev/5f3c1d227089 .

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fbf43c56b4c
Add missing mLoading assignments in {nsHTMLFramesetFrame,nsHTMLFramesetBorderFrame}::GetCursor.  r=dbaron.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2fbf43c56b4c