Closed Bug 1320126 Opened 4 years ago Closed 3 years ago

Remove unused chrome://browser/skin/keyhole-forward-mask.svg file

Categories

(Firefox :: Theme, defect, P3)

Unspecified
Windows
defect

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: florian, Assigned: pass2pawan)

References

Details

Attachments

(1 file)

Reported as unreferenced by the test I'm working on in bug 1316187.

This file was introduced in bug 544999 but the reference to it was commented out. The last (commented out) reference has been removed in bug 997131 (https://hg.mozilla.org/mozilla-central/rev/0ff00dde7e0c#l7.31).
Priority: -- → P3
Hello i would like to patch this bug and similar ones in this dependency tree bug 1316187 (https://bugzilla.mozilla.org/showdependencytree.cgi?id=1316187&hide_resolved=1), but when i try to remove and then build firefox i get an error saying the same files are missing , have the references really been commented out ?
(In reply to pass2pawan from comment #1)
> Hello i would like to patch this bug and similar ones in this dependency
> tree bug 1316187

Nice :-)

> when i try to remove and then build
> firefox i get an error saying the same files are missing , have the
> references really been commented out ?

Files that are packaged in chrome:// are referenced in a packaging manifest, a jar.mn file.

Here it's at http://searchfox.org/mozilla-central/rev/a712d69adb9b2588f88aff678216b2be94d3719c/browser/themes/windows/jar.mn#18

Have you removed that line when you tried building?
Attachment #8826179 - Flags: review?(florian)
Comment on attachment 8826179 [details] [diff] [review]
bug-1320126.patch

Looks good to me, thanks!
Attachment #8826179 - Flags: review?(florian) → review+
I had to apply the change to jar.mn by hand because your tree doesn't contain this change yet https://hg.mozilla.org/mozilla-central/diff/5e444885af53/browser/themes/windows/jar.mn

Please update your tree before creating patches next time :-).
https://hg.mozilla.org/integration/mozilla-inbound/rev/2815d3833df6436abf2f466a96204261135b6a81
Bug 1320126 - Remove unused chrome://browser/skin/keyhole-forward-mask.svg file, r=florian.
https://hg.mozilla.org/mozilla-central/rev/2815d3833df6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Hello , will i be assigned these bugs ? and what do you mean by updating my tree ?
(In reply to pass2pawan from comment #8)
> Hello , will i be assigned these bugs ?

Yes, I thought it would happen automatically with the script resolving the bugs, but apparently it didn't.

> and what do you mean by updating my tree ?

Before starting new work, you need to do:
  hg pull
and
  hg update

The first command will download the new changes that were made by others, and the second will apply these changes to your local copy of the source code.
Assignee: nobody → pass2pawan
You need to log in before you can comment on or make changes to this bug.