1320139 - All synced bookmarks and history missing associated title 'letter' as default favicon

Status: RESOLVED FIXED

(Firefox for iOS :: Theme & Visual Design, defect, P1)

Description

[Aaron Train [:aaronmt]]

Attachment: IMG_0006.PNG

=> Install master (5d7484)
=> Sign into Firefox Accounts
=> See bookmarks and history

See screenshot.

Expected: The first character of the title fill in their default Favicon

Actual: An empty square next to all my entries

On long-tap they appear. It looks like a styling issue.

Comment 1

[Aaron Train [:aaronmt]]

Maybe related to bug 1318670

Comment 2

[Farhan Patel [:farhan]]

Attachment: Pull Request

Comment 4

[Maurya Talisetti]

Attachment: Background colors in AS

Farhan, the AS top-sites and highlights are now having that background color too!

Comment 5

[Farhan Patel [:farhan]]

Hmm. I knew that would happen. But I'm surprised the colors dont match.

Comment 6

[Farhan Patel [:farhan]]

Ah. I see. The letters of the Alphabet are cached. So it keeps the color of the last one.

Comment 7

[Farhan Patel [:farhan]]

So this only breaks AS right now which is only on master. So lets still get this half working fix into 6.x because otherwise users wont see any favicons in their bookmarks.

Comment 8

[Stephan Leroux [:sleroux]]

v6.x 5875608

Comment 9

[Simon Basca [:SimonB]]

The favicon is correctly displayed on master 6dae35c6.

Comment 10

[Maurya Talisetti]

Simon, but the AS top-sites and highlights are still showing the background color as in attachment 8816368 [details]

Comment 11

[Simon Basca [:SimonB]]

Per #comment 7, my understanding is that this patch only fixes the favicon for synced bookmarks and history panel. I believe that the AS top - sites and highlights is a separate issue. I will log a new bug for that issue.