Closed
Bug 1320143
Opened 8 years ago
Closed 8 years ago
Remove String generics uses in mobile/android/chrome/content
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox53 fixed)
RESOLVED
FIXED
Firefox 53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(1 file)
|
1.10 KB,
patch
|
sebastian
:
review+
|
Details | Diff | Splinter Review |
The various String generic methods are non-standard APIs and we plan to warn when they're used (bug 1319926) and eventually want to remove them completely (bug 1222552). As a first step we need to replace all String generic uses in Firefox with the counterpart from String.prototype. In mobile/android/chrome/content/browser.js, String.trim needs to be replaced with a call to String.prototype.trim.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8814234 -
Flags: review?(s.kaspari)
|
||
Updated•8 years ago
|
Attachment #8814234 -
Flags: review?(s.kaspari) → review+
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/26551118afb7 Remove String generics uses in mobile/android/chrome/content. r=sebastian
Keywords: checkin-needed
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/26551118afb7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•