Closed Bug 1320143 Opened 3 years ago Closed 3 years ago

Remove String generics uses in mobile/android/chrome/content

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: anba, Assigned: anba)

References

Details

Attachments

(1 file)

The various String generic methods are non-standard APIs and we plan to warn when they're used (bug 1319926) and eventually want to remove them completely (bug 1222552). As a first step we need to replace all String generic uses in Firefox with the counterpart from String.prototype.


In mobile/android/chrome/content/browser.js, String.trim needs to be replaced with a call to String.prototype.trim.
Attached patch bug1320143.patchSplinter Review
Attachment #8814234 - Flags: review?(s.kaspari)
Attachment #8814234 - Flags: review?(s.kaspari) → review+
Thanks for reviewing!
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26551118afb7
Remove String generics uses in mobile/android/chrome/content. r=sebastian
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/26551118afb7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.