Closed Bug 1320145 Opened 3 years ago Closed 3 years ago

Port remaining GETPROP stubs to CacheIR

Categories

(Core :: JavaScript Engine: JIT, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

After bug 1317703 and bug 1319437 land, all that will be left for GETPROP are the stubs for the string length and length/callee on magic arguments.

I think these will be easy to convert. One issue is that currently all CacheIR operands are Values or Objects and to support strings etc we have to change a few things, but nothing too bad I hope.
Priority: -- → P1
This ports the string length stub to CacheIR.
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Attachment #8814888 - Flags: review?(nicolas.b.pierron)
This ports the stubs for callee/length on lazy arguments.

 7 files changed, 91 insertions(+), 187 deletions(-)
Attachment #8814889 - Flags: review?(nicolas.b.pierron)
Blocks: 1320670
Comment on attachment 8814888 [details] [diff] [review]
Part 1 - String length

Review of attachment 8814888 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/CacheIR.h
@@ +94,5 @@
> +    MOZ_IMPLICIT TypedOperandId(ObjOperandId id)
> +      : OperandId(id.id()), type_(JSVAL_TYPE_OBJECT)
> +    {}
> +    MOZ_IMPLICIT TypedOperandId(StringOperandId id)
> +      : OperandId(id.id()), type_(JSVAL_TYPE_STRING)

Nice way to use compiler static type information to map to the corresponding constant, and avoid code duplication :)
Attachment #8814888 - Flags: review?(nicolas.b.pierron) → review+
Comment on attachment 8814889 [details] [diff] [review]
Part 2 - Magic arguments

Review of attachment 8814889 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8814889 - Flags: review?(nicolas.b.pierron) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a6b69786d1e
part 1 - Port string.length stub to CacheIR. r=nbp
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e0998e9e1d0
part 2 - Port length/callee stubs on lazy arguments to CacheIR. r=nbp
https://hg.mozilla.org/mozilla-central/rev/7a6b69786d1e
https://hg.mozilla.org/mozilla-central/rev/2e0998e9e1d0
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.