1320145 - Port remaining GETPROP stubs to CacheIR

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P1)

Description

[Jan de Mooij [:jandem]]

After bug 1317703 and bug 1319437 land, all that will be left for GETPROP are the stubs for the string length and length/callee on magic arguments.

I think these will be easy to convert. One issue is that currently all CacheIR operands are Values or Objects and to support strings etc we have to change a few things, but nothing too bad I hope.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Part 1 - String length

This ports the string length stub to CacheIR.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Part 2 - Magic arguments

This ports the stubs for callee/length on lazy arguments.

 7 files changed, 91 insertions(+), 187 deletions(-)

Comment 3

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8814888 [details] [diff] [review]
Part 1 - String length

Review of attachment 8814888 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/CacheIR.h
@@ +94,5 @@
> +    MOZ_IMPLICIT TypedOperandId(ObjOperandId id)
> +      : OperandId(id.id()), type_(JSVAL_TYPE_OBJECT)
> +    {}
> +    MOZ_IMPLICIT TypedOperandId(StringOperandId id)
> +      : OperandId(id.id()), type_(JSVAL_TYPE_STRING)

Nice way to use compiler static type information to map to the corresponding constant, and avoid code duplication :)

Comment 4

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8814889 [details] [diff] [review]
Part 2 - Magic arguments

Review of attachment 8814889 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a6b69786d1e
part 1 - Port string.length stub to CacheIR. r=nbp
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e0998e9e1d0
part 2 - Port length/callee stubs on lazy arguments to CacheIR. r=nbp

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7a6b69786d1e
https://hg.mozilla.org/mozilla-central/rev/2e0998e9e1d0