1320156 - Remove leftover Privacy-16.png file

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Florian Quèze [:florian]]

Bug 1259340 (https://hg.mozilla.org/mozilla-central/rev/463fc6d36ff5#l2.15) removed the reference to Privacy-16.png, but chrome://browser/skin/Privacy-16.png is still shipped on Linux and the following files, although not shipped, are still in the tree:
 browser/themes/osx/Privacy-16.png
 browser/themes/windows/Privacy-16-XP.png
 browser/themes/windows/Privacy-16.png

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

interesting, there are various add-ons referring to chrome://browser/skin/Privacy-16.png, that means they are broken out of Linux:

https://addons.mozilla.org/it/firefox/addon/menu-icons-plus/ (8k users)
https://addons.mozilla.org/en-US/firefox/addon/openinprivatewindow/ (2k users)
Firefox Homepage by "Mozilla Online Limited" (unknown # of users)
SecureTunnel Plugin for Firefox (unknown # of users)

So, either we fix Windows/Mac, or we also break Linux.
Considering the market share on the platforms, I think we should just break Linux.

It would be useful to reach the devs and notify they can use chrome://browser/skin/privatebrowsing/favicon.svg or chrome://browser/skin/privatebrowsing/private-browsing.svg (they look the same to me, why do we have 2 sizes for an svg?)

Comment 2

[pass2pawan]

There are actually 4 instances of Privacy-16 shipped , should i remove them all?

Comment 3

[Florian Quèze [:florian]]

(In reply to pass2pawan from comment #2)
> There are actually 4 instances of Privacy-16 shipped , should i remove them
> all?

I think so, but http://searchfox.org/mozilla-central/search?q=Privacy-16 only shows me 3 files, where is the 4th?

Comment 4

[pass2pawan]

one in linux , 2 in windows and one in osx?

Comment 5

[Florian Quèze [:florian]]

browser/themes/windows/Privacy-16-XP.png no longer exists.

Comment 6

[pass2pawan]

Attachment: bug-1320156.patch

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 8826595 [details] [diff] [review]
bug-1320156.patch

You need to update your tree. The Privacy-16-XP.png file has been removed already, so this patch won't apply.

And the patch needs to remove the reference at http://searchfox.org/mozilla-central/source/browser/themes/linux/jar.mn#29

Comment 8

[pass2pawan]

yes i did update my tree , the Privacy-16-XP file is still present

Comment 9

[pass2pawan]

and can you tell me the command to revert my folder back ? i cant seem to go back to having those files , and since i patched some other bug i cant use hg revert and i tried histedit to no avail

Comment 10

[Florian Quèze [:florian]]

(In reply to pass2pawan from comment #9)
> and can you tell me the command to revert my folder back ? i cant seem to go
> back to having those files , and since i patched some other bug i cant use
> hg revert and i tried histedit to no avail

It's going to be difficult to help you here in bug comments for how to decide which hg command you need to run. It's likely going to be easier if you ask on irc in the #introduction channel.

Comment 11

[Dan Banner]

Attachment: Bug 1320156 - Remove leftover Privacy-16.png files.

Review commit: https://reviewboard.mozilla.org/r/136882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136882/

Comment 12

[Florian Quèze [:florian]]

Comment on attachment 8865213 [details]
Bug 1320156 - Remove leftover Privacy-16.png files.

https://reviewboard.mozilla.org/r/136882/#review140542

Thanks!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66e287ef3480
Remove leftover Privacy-16.png files. r=florian

Comment 14

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/66e287ef3480