Closed
Bug 1320189
Opened 9 years ago
Closed 9 years ago
WebChannelMessageToContent listener does not forward errors finding a handler
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: vladikoff, Assigned: vladikoff)
References
()
Details
Attachments
(1 file)
Errors are sent from here: https://dxr.mozilla.org/mozilla-central/rev/34fce7c12173bdd6dda54c2ebf6d344252f1ac48/toolkit/modules/WebChannel.jsm#138
They are not processed by the `browser-content.js` script and are dropped: https://dxr.mozilla.org/mozilla-central/rev/34fce7c12173bdd6dda54c2ebf6d344252f1ac48/toolkit/content/browser-content.js#923
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•9 years ago
|
||
Mark, I don't think the reporting that we have in that file ever worked. I'm making a change to align it more with the format that Kit added earlier this year
Ref: https://bugzilla.mozilla.org/show_bug.cgi?id=1255302
Ref: https://github.com/mozilla/fxa-content-server/issues/3668
Comment 3•9 years ago
|
||
Updating the title - it turns out that unhandled exceptions in the listeners are reported to content, but errors generated by _sendErrorEventToContent are not. These latter ones are when we can't find a handler to use, or decline to use one due to a mismatched principal.
Summary: WebChannelMessageToContent listener does not forward errors to content → WebChannelMessageToContent listener does not forward errors finding a handler
Comment hidden (mozreview-request) |
Comment 5•9 years ago
|
||
mozreview-review |
Comment on attachment 8814248 [details]
Bugzilla #1320189 - Fix WebChannel error reporting for content errors
https://reviewboard.mozilla.org/r/95488/#review95600
Attachment #8814248 -
Flags: review?(markh) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•9 years ago
|
||
mozreview-review-reply |
Comment on attachment 8814248 [details]
Bugzilla #1320189 - Fix WebChannel error reporting for content errors
https://reviewboard.mozilla.org/r/95488/#review95600
There are some changes that need to be made to the remoteTroubleshoot, updating that and resubmitting for Try...
Assignee | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8144961dead7492bdbfc6e7dde081e555d13ac98
Bug 1320189 - Fix WebChannel error reporting for content errors r=markh
Comment 9•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•