Closed
Bug 1320284
Opened 9 years ago
Closed 9 years ago
Switch WebRender by Pref
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(2 files, 3 obsolete files)
|
6.91 KB,
patch
|
Details | Diff | Splinter Review | |
|
5.71 KB,
patch
|
Details | Diff | Splinter Review |
We should not create CompositorVsyncScheduler in CompositorBridgeParent::Initialize().
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
WebRenderBridgeParent::WebRenderBridgeParent creates CompositorVsyncScheduler when webrender is enabled.
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8814341 -
Flags: review?(nical.bugzilla)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8814341 [details] [diff] [review]
patch - Suppress CompositorVsyncScheduler creation
Review of attachment 8814341 [details] [diff] [review]:
-----------------------------------------------------------------
Maybe it would make sense to check the webrender pref instead of using #ifdefs? I assume we already have this pref, otherwise we'll have to add it since we'll need to be able to switch WR on and off without rebuilding firefox.
Attachment #8814341 -
Flags: feedback+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8814341 -
Flags: review?(nical.bugzilla)
|
|
Assignee | |
Comment 4•9 years ago
|
||
(In reply to Nicolas Silva [:nical] from comment #3)
>
> Maybe it would make sense to check the webrender pref instead of using
> #ifdefs? I assume we already have this pref, otherwise we'll have to add it
> since we'll need to be able to switch WR on and off without rebuilding
> firefox.
Oh, I forgot about it.
|
|
Assignee | |
Updated•9 years ago
|
Summary: CompositorVsyncScheduler is created in CompositorBridgeParent::Initialize() → Switch WebRender by Pref
|
|
Assignee | |
Comment 5•9 years ago
|
||
Attachment #8814341 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8816371 -
Flags: review?(nical.bugzilla)
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/53a19f05f274
Switch WebRender by Pref r=nical?
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8816371 -
Flags: review?(nical.bugzilla)
|
||
Comment 7•9 years ago
|
||
Please address vlad's comment at https://gfx.tacowolf.com/rQ53a19f05f274
Flags: needinfo?(sotaro.ikeda.g)
|
|
Assignee | |
Comment 8•9 years ago
|
||
Sorry, I am going to address it.
|
|
Assignee | |
Comment 9•9 years ago
|
||
Flags: needinfo?(sotaro.ikeda.g)
|
|
Assignee | |
Comment 10•9 years ago
|
||
Attachment #8818474 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 11•9 years ago
|
||
Attachment #8818476 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8818477 -
Flags: review?(nical.bugzilla)
|
||
Comment 12•9 years ago
|
||
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/ef45f3844967
Remove some MOZ_ENABLE_WEBRENDER r=nical?
|
|
Assignee | |
Comment 13•9 years ago
|
||
Comment on attachment 8818477 [details] [diff] [review]
patch - Remove some MOZ_ENABLE_WEBRENDER
Moved a review to Phabricator.
Attachment #8818477 -
Flags: review?(nical.bugzilla)
|
|
||
Updated•9 years ago
|
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•