Closed Bug 1320284 Opened 5 years ago Closed 4 years ago

Switch WebRender by Pref

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(2 files, 3 obsolete files)

We should not create CompositorVsyncScheduler in CompositorBridgeParent::Initialize().
WebRenderBridgeParent::WebRenderBridgeParent creates CompositorVsyncScheduler when webrender is enabled.
Assignee: nobody → sotaro.ikeda.g
Blocks: webrender
Attachment #8814341 - Flags: review?(nical.bugzilla)
Comment on attachment 8814341 [details] [diff] [review]
patch - Suppress  CompositorVsyncScheduler  creation

Review of attachment 8814341 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe it would make sense to check the webrender pref instead of using #ifdefs? I assume we already have this pref, otherwise we'll have to add it since we'll need to be able to switch WR on and off without rebuilding firefox.
Attachment #8814341 - Flags: feedback+
Attachment #8814341 - Flags: review?(nical.bugzilla)
(In reply to Nicolas Silva [:nical] from comment #3)
> 
> Maybe it would make sense to check the webrender pref instead of using
> #ifdefs? I assume we already have this pref, otherwise we'll have to add it
> since we'll need to be able to switch WR on and off without rebuilding
> firefox.

Oh, I forgot about it.
Summary: CompositorVsyncScheduler is created in CompositorBridgeParent::Initialize() → Switch WebRender by Pref
Attachment #8814341 - Attachment is obsolete: true
Attachment #8816371 - Flags: review?(nical.bugzilla)
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/53a19f05f274
Switch WebRender by Pref r=nical?
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Attachment #8816371 - Flags: review?(nical.bugzilla)
Please address vlad's comment at https://gfx.tacowolf.com/rQ53a19f05f274
Flags: needinfo?(sotaro.ikeda.g)
Sorry, I am going to address it.
Flags: needinfo?(sotaro.ikeda.g)
Attachment #8818474 - Attachment is obsolete: true
Attachment #8818476 - Attachment is obsolete: true
Attachment #8818477 - Flags: review?(nical.bugzilla)
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/ef45f3844967
Remove some MOZ_ENABLE_WEBRENDER r=nical?
Comment on attachment 8818477 [details] [diff] [review]
patch - Remove some MOZ_ENABLE_WEBRENDER

Moved a review to Phabricator.
Attachment #8818477 - Flags: review?(nical.bugzilla)
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.