Closed Bug 1320318 Opened 8 years ago Closed 7 years ago

Popup notification labels and descriptions are misaligned

Categories

(Toolkit :: Themes, defect, P3)

Product:
Toolkit
Component:
Themes
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla53
Iteration:
53.3 - Dec 26
Tracking Flags:
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- verified
firefox54 --- verified

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: regression, Whiteboard: [fxprivacy])

Attachments

(2 files)

screenshots
326.39 KB, image/png
Details
patch
697 bytes, patch
jkt
: review+
Details | Diff | Splinter Review
Attached image screenshots — 
Popup notification labels / descriptions don't line up with <popupnotificationcontent> contents. See before/after screenshots.

This is because of this rule:

https://hg.mozilla.org/mozilla-central/rev/d04cc86f4313#l12.23
Flags: needinfo?(jkt)
This is even more visible on the screen sharing permission prompt when there's a preview displayed.
Priority: -- → P3
Whiteboard: [fxprivacy]
Attached patch patch — — Splinter Review 

        Attachment #8819678 -
        Flags: review?(jkt)
Iteration: --- → 53.3 - Dec 26
Flags: qe-verify?

    
    

    
  
Comment on attachment 8819678 [details] [diff] [review]
patch

Review of attachment 8819678 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, these lines were needed with a different layout setup that we were using to my memory. Patch works from my testing of the various popups.

        Attachment #8819678 -
        Flags: review?(jkt) → review+

    
  
Assignee: nobody → dao+bmo
Flags: needinfo?(jkt)

    
    

    
  
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcf124d76193
Make popup-notification-body labels and descriptions line up with other elements in the popup. r=jkt

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/bcf124d76193
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox53:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

    
    

    
  
Build ID: 20170208030203
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0

Verified as fixed on on Windows 10 x 64, Mac OS X 10.11 and Ubuntu 16.04 x64 on Firefox Nightly 54.0a1, Firefox Nightly 53.0a1 and Aurora 53.0a2.
Status: RESOLVED → VERIFIED

          status-firefox53:
          fixed → verified

          status-firefox54:
          --- → verified

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: