Closed Bug 1320348 Opened 8 years ago Closed 8 years ago

"PresentationControlService.js: PresentationControlService - close" appears in all mochitest output

Categories

(Core :: DOM: Core & HTML, defect)

53 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: florian, Assigned: schien)

References

Details

Attachments

(1 file)

When I run locally the browser chrome mochitest I'm currently writing, I have this line at the end of the output:

-*- PresentationControlService.js: PresentationControlService - close


Either http://searchfox.org/mozilla-central/rev/9a3ab17838f039aab023837d905115f8990e442e/dom/presentation/provider/PresentationControlService.js#319 should be removed (it doesn't seem very useful even for debugging), or dom.presentation.tcp_server.debug should only be set to true in the tests that are relevant to PresentationControlService.js instead of globally at http://searchfox.org/mozilla-central/rev/9a3ab17838f039aab023837d905115f8990e442e/testing/profiles/prefs_general.js#237
Flags: needinfo?(schien)
I can remove the global pref and only turn on it in related test cases.
Assignee: nobody → schien
Attachment #8814774 - Flags: review?(schien)
Comment on attachment 8814774 [details]
Bug 1320348 - disable Presentation API logging on treeherder.

https://reviewboard.mozilla.org/r/95878/#review95870
Attachment #8814774 - Flags: review?(schien) → review+
Pushed by schien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cbd4fb9f368e
disable Presentation API logging on treeherder. r=schien
https://hg.mozilla.org/mozilla-central/rev/cbd4fb9f368e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Flags: needinfo?(schien)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: