Closed Bug 1320362 Opened 3 years ago Closed 3 years ago

Move indexedDb storage type in the storage inspector into a new column

Categories

(DevTools :: Storage Inspector, defect, P2)

defect

Tracking

(firefox53 fixed)

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: miker, Assigned: miker)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

We should move indexedDb storage type in the storage inspector into a new column as the current display is too crowded.

This involves creating a compound primary key in the same way we did for the cookie table and will require a lot of test changes.
Comment on attachment 8815343 [details]
Bug 1320362 - Move indexedDb storage type in the storage inspector into a new column

https://reviewboard.mozilla.org/r/96306/#review96742

Thanks for the patch Mike, that's a great improvement!

Do we want to keep surfacing the "uniqueKey" information in the UI in the feature (in the object details panel)
I understand keeping it makes the patch simpler and avoids changing too many tests but I don't think it is really relevant for the user.

::: devtools/server/actors/storage.js:1687
(Diff revision 1)
>        };
>      }
>      if ("objectStores" in item) {
>        // DB meta data
>        return {
> +        uniqueKey: `${item.name} (${item.storage})`,

Maybe move uniqueKey in last position in this object so that it is displayed last in the UI? Up to you.
Attachment #8815343 - Flags: review?(jdescottes) → review+
Comment on attachment 8815343 [details]
Bug 1320362 - Move indexedDb storage type in the storage inspector into a new column

https://reviewboard.mozilla.org/r/96306/#review96742

No we don't want to do that... I have added a simple change that hides private fields in the sidebar.

This doesn't break any tests so we are fine from a testing perspective.

> Maybe move uniqueKey in last position in this object so that it is displayed last in the UI? Up to you.

Or even stop private fields from being displayed at all... done.
Just tested and reviewed that last version of your changeset. 
Works and looks great!
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/65c73bad7dc1
Move indexedDb storage type in the storage inspector into a new column r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/65c73bad7dc1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.