1320362 - Move indexedDb storage type in the storage inspector into a new column

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, defect, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We should move indexedDb storage type in the storage inspector into a new column as the current display is too crowded.

This involves creating a compound primary key in the same way we did for the cookie table and will require a lot of test changes.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1320362 - Move indexedDb storage type in the storage inspector into a new column

Ideally we would have used the GUID to join fields to build the compound key but because we show the uniqueId in the tree that would lead to an ugly user experience. As an
alternative we simply use e.g. db1 (default) as the uniqueId. This works as a unique key, is informative for the user and means minimal changes to tests.

Review commit: https://reviewboard.mozilla.org/r/96306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96306/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8815343 [details]
Bug 1320362 - Move indexedDb storage type in the storage inspector into a new column

https://reviewboard.mozilla.org/r/96306/#review96742

Thanks for the patch Mike, that's a great improvement!

Do we want to keep surfacing the "uniqueKey" information in the UI in the feature (in the object details panel)
I understand keeping it makes the patch simpler and avoids changing too many tests but I don't think it is really relevant for the user.

::: devtools/server/actors/storage.js:1687
(Diff revision 1)
>        };
>      }
>      if ("objectStores" in item) {
>        // DB meta data
>        return {
> +        uniqueKey: `${item.name} (${item.storage})`,

Maybe move uniqueKey in last position in this object so that it is displayed last in the UI? Up to you.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8815343 [details]
Bug 1320362 - Move indexedDb storage type in the storage inspector into a new column

https://reviewboard.mozilla.org/r/96306/#review96742

No we don't want to do that... I have added a simple change that hides private fields in the sidebar.

This doesn't break any tests so we are fine from a testing perspective.

> Maybe move uniqueKey in last position in this object so that it is displayed last in the UI? Up to you.

Or even stop private fields from being displayed at all... done.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8815343 [details]
Bug 1320362 - Move indexedDb storage type in the storage inspector into a new column

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/96306/diff/1-2/

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Looks like hg amend has done something funky with this patch... fixing.

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8815343 [details]
Bug 1320362 - Move indexedDb storage type in the storage inspector into a new column

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/96306/diff/2-3/

Comment 7

[Julian Descottes [:jdescottes]]

Just tested and reviewed that last version of your changeset. 
Works and looks great!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65c73bad7dc1
Move indexedDb storage type in the storage inspector into a new column r=jdescottes

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/65c73bad7dc1

Comment 10

[Will Bamberg [:wbamberg]]

Updated: https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector#IndexedDB