1320375 - Remove webrtcUI.showSharingDoorhanger's obsolete aType parameter

Status: RESOLVED FIXED

(Firefox :: Site Permissions, defect)

Description

[Florian Quèze [:florian]]

Since bug 1206233 we show the control center panel when clicking the global webrtc sharing indicator instead of the separate camera/microphone and screen sharing doorhangers, so we no longer need to preserve the information about which doorhanger should be opened. Time to cleanup!

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8814485 [details] [diff] [review]
Patch

Review of attachment 8814485 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, I should've caught that in my review of bug 1206233 :)

Comment 3

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/77b01f2bda7f4737ad3573103c05ccea895d1a39
Bug 1320375 - Remove webrtcUI.showSharingDoorhanger's obsolete aType parameter, r=johannh.

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f905fe26e901
Backed out changeset 77b01f2bda7f

Comment 5

[Carsten Book [:Tomcat]]

backed this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=670ad168fb708a7eca83480419f6206833b2566e because of continued test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=39930510&repo=mozilla-inbound

maybe this need a try run to find out what was going wrong

Comment 6

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d13fd025112b2e9da6433815bc2fc2abe0f883c
Bug 1320375 - Remove webrtcUI.showSharingDoorhanger's obsolete aType parameter, r=johannh.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d13fd025112