Closed
Bug 1320375
Opened 5 years ago
Closed 5 years ago
Remove webrtcUI.showSharingDoorhanger's obsolete aType parameter
Categories
(Firefox :: Site Permissions, defect)
Firefox
Site Permissions
Tracking
()
RESOLVED
FIXED
Firefox 53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
Details
(Whiteboard: [fxprivacy])
Attachments
(1 file)
|
8.93 KB,
patch
|
johannh
:
review+
|
Details | Diff | Splinter Review |
Since bug 1206233 we show the control center panel when clicking the global webrtc sharing indicator instead of the separate camera/microphone and screen sharing doorhangers, so we no longer need to preserve the information about which doorhanger should be opened. Time to cleanup!
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #8814485 -
Flags: review?(jhofmann)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 8814485 [details] [diff] [review] Patch Review of attachment 8814485 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, I should've caught that in my review of bug 1206233 :)
Attachment #8814485 -
Flags: review?(jhofmann) → review+
|
|
Assignee | |
Comment 3•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/77b01f2bda7f4737ad3573103c05ccea895d1a39 Bug 1320375 - Remove webrtcUI.showSharingDoorhanger's obsolete aType parameter, r=johannh.
Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f905fe26e901 Backed out changeset 77b01f2bda7f
|
||
Comment 5•5 years ago
|
||
backed this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=670ad168fb708a7eca83480419f6206833b2566e because of continued test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=39930510&repo=mozilla-inbound maybe this need a try run to find out what was going wrong
Flags: needinfo?(florian)
|
||
Updated•5 years ago
|
Whiteboard: [fxprivacy][triage] → [fxprivacy]
|
|
Assignee | |
Comment 6•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d13fd025112b2e9da6433815bc2fc2abe0f883c Bug 1320375 - Remove webrtcUI.showSharingDoorhanger's obsolete aType parameter, r=johannh.
|
|
Assignee | |
Updated•5 years ago
|
Flags: needinfo?(florian)
|
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4d13fd025112
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in
before you can comment on or make changes to this bug.
Description
•