Remove webrtcUI.showSharingDoorhanger's obsolete aType parameter

RESOLVED FIXED in Firefox 53

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

unspecified
Firefox 53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [fxprivacy])

Attachments

(1 attachment)

Since bug 1206233 we show the control center panel when clicking the global webrtc sharing indicator instead of the separate camera/microphone and screen sharing doorhangers, so we no longer need to preserve the information about which doorhanger should be opened. Time to cleanup!
Posted patch PatchSplinter Review
Attachment #8814485 - Flags: review?(jhofmann)
Comment on attachment 8814485 [details] [diff] [review]
Patch

Review of attachment 8814485 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, I should've caught that in my review of bug 1206233 :)
Attachment #8814485 - Flags: review?(jhofmann) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/77b01f2bda7f4737ad3573103c05ccea895d1a39
Bug 1320375 - Remove webrtcUI.showSharingDoorhanger's obsolete aType parameter, r=johannh.
backed this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=670ad168fb708a7eca83480419f6206833b2566e because of continued test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=39930510&repo=mozilla-inbound

maybe this need a try run to find out what was going wrong
Flags: needinfo?(florian)
Whiteboard: [fxprivacy][triage] → [fxprivacy]
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d13fd025112b2e9da6433815bc2fc2abe0f883c
Bug 1320375 - Remove webrtcUI.showSharingDoorhanger's obsolete aType parameter, r=johannh.
Flags: needinfo?(florian)
https://hg.mozilla.org/mozilla-central/rev/4d13fd025112
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.