1320521 - Duplicate bookmarks create duplicate shortcuts in the Top Sites Panel

Status: RESOLVED DUPLICATE of bug 1382332

(Firefox for Android Graveyard :: Awesomescreen, defect, P2)

Description

[Rolcol]

Attachment: Screenshot of duplicate ars technica tiles

When there are multiple bookmarks to the same site, Firefox for Android will create duplicate shortcut tiles in the Top Sites panel of the home screen.  Attached is a screenshot of Aurora v52 running on a Nexus 7 (2012).  

The expected behavior is not to have duplicate tiles to the same site.

As you can see, there are 3 tiles pointing to Ars Technica.  I had 3 bookmarks pointing to it: 1 in Bookmarks Menu, 1 in Other Bookmarks, and 1 in Mobile Bookmarks.  They all pointed to the same URL of http://arstechnica.com/ 

When I deleted all but the Bookmarks Menu bookmark in the desktop bookmark manager, forced the 2 devices to Sync Now, and swiped away Aurora from the multitasking overview, the duplicate tiles went away.

Devices:
Firefox Beta v51.0b3 on macOS 10.12.1 
Firefox Aurora v52.0a2 updated daily on Nexus 7 (2012) running a custom ROM.  Android v6.0.1

Comment 1

[Sorina Florean [:sflorean]]

Attachment: Screenshot_20161205-222205.jpg

Thank you for report!
Tested with Asus ZenPad 8 (Android 6.0.1) and the issue is reproducible on all branches. I will change the status to New and set the flags accordingly.

Comment 2

[Julien Cristau [:jcristau]]

Too late for firefox 52, mass-wontfix.

Comment 3

[Sorina Florean [:sflorean]]

Attachment: Screenshot_2017_04_21_Top_Sites.png_Photos.png

This is the behavior of this bug in Firefox 54 Beta 1. And Switch to tab is shown for one URL (https://people-mozilla.org/~fqueze2/webrtc/).

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[triage]
P2, and maybe even P3 if we will have clear timeline for activity stream landing in the near future.

Comment 5

[Andrzej Hunt :ahunt]

We might just need to deduplicate URLs when querying the frecency based topsites from the combined table, i.e. at:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/db/BrowserProvider.java#1071

Note: the same URL could conceivably be pinned multiple times - that means we can't deduplicate later in getTopSites(), we need to do it as early as possible, i.e. when fetching the pure topsites (before pinned/suggested sites are added).

IIRC we use the same query for AS, so this is probably independent of AS being enabled.

Comment 6

[Varun Iyer]

Hi, may I please work on this bug?

Comment 7

[Varun Iyer]

Attachment: Bug 1320521 - Duplicate bookmarks create duplicate shortcuts in the Top Sites Panel

Review commit: https://reviewboard.mozilla.org/r/144740/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144740/

Comment 8

[Varun Iyer]

If I can work on it, what URLs are considered duplicates? Are they considered duplicates when they are exact copies or a subpages. For example, there can be facebook.com and facebook.com/home in the top sites. In this case, should they both be included? If not, which one should be displayed?

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I will be fixing this as part of bug 1382332.

I'm sorry no one got back to you, Varun and that now the issue will be fixed. If you would like to have another bug to work on, please add a needinfo flag for me and respond to this message.