1320539 - Add LZ4 support to JSON after using Backup... manually when exporting bookmarks

Status: VERIFIED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

STR:
1. Go to Library (Ctrl+Shift+B)
2. Press "Import and Backup" button
3. In shown menu press "Backup..."
4. See that exported and backuped bookmarks is in only uncompressed mode in JSON, instead of compressed mode in JSONLZ4

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

we use lz4 only for automatic backups, manual backups are uncompressed cause the lz4 format we use lacks the "standard" header, so it would be confusing for the user to save to a specific position a file he can't read easily.
He could zip the json though if he'd want.

Just to be sure, when you say "backuped bookmarks" you mean the one in bookmarkBackups folder? Since that would be a bug, when the user manually backups we should store uncompressed to the choosen folder and copy that compressed to the profile backups folder.

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Marco Bonardo [::mak] from comment #1)
> we use lz4 only for automatic backups, manual backups are uncompressed
> He could zip the json though if he'd want.
> [...]
> when the user manually
> backups we should store uncompressed to the choosen folder and copy that
> compressed to the profile backups folder.
LZ4 should be also used for manual backups
or at least option to select JSON and JSONLZ4 should be available,
as you can restore JSONLZ4 without any problem, same as JSON,
by going to Library (Ctrl+Shift+B), next pressing "Import and Backup" button, next selecting "Restore" and last pressing "Choose File..." submenu option.
It's to save space and minimizing complexity of actions and overall time to complete task.

(In reply to Marco Bonardo [::mak] from comment #1)
> [...] cause
> the lz4 format we use lacks the "standard" header, so it would be confusing
> for the user to save to a specific position a file he can't read easily.
Was there any reason to not use "standard" LZ4 format header?

(In reply to Marco Bonardo [::mak] from comment #1)
> Just to be sure, when you say "backuped bookmarks" you mean the one in
> bookmarkBackups folder? Since that would be a bug
No. I meant by manual exporting bookmarks as JSON file, as I stated in STR.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #2)
> (In reply to Marco Bonardo [::mak] from comment #1)
> > [...] cause
> > the lz4 format we use lacks the "standard" header, so it would be confusing
> > for the user to save to a specific position a file he can't read easily.
> Was there any reason to not use "standard" LZ4 format header?

Bug 1209390.

> (In reply to Marco Bonardo [::mak] from comment #1)
> > Just to be sure, when you say "backuped bookmarks" you mean the one in
> > bookmarkBackups folder? Since that would be a bug
> No. I meant by manual exporting bookmarks as JSON file, as I stated in STR.

Regardless, lz4 is not a standard compression format that a user can open easily (most OSs only support zip out of the box), and I don't want users to have to guess how to open that file to move their json bookmarks to some third party service or such. Manual exporting should still use a format any user can easily understand, and if you have special space needs, you should likely use your own compressor, or use a compressed disk.
I'm sorry, no plan to change this atm.

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Fair enough answer, thank you very much.