1320560 - use C99 isfinite() for all modern libc implementations

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Jory A. Pratt [:anarchy]]

Attachment: Use-C99-math-isfinite.patch

Patch is straight forward, modern libc implementations do no use finite.

Comment 1

[James Cheng[:JamesCheng]]

Comment on attachment 8814704 [details] [diff] [review]
Use-C99-math-isfinite.patch

Review of attachment 8814704 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/ds/nsMathUtils.h
@@ +107,5 @@
>    // Darwin has deprecated |finite| and recommends |isfinite|. The former is
>    // not present in the iOS SDK.
>    return std::isfinite(aNum);
>  #else
> +  return isfinite(aNum);

Is isfinite different from std::isfinite? If it is the same, could it be merged into above elif?

Comment 2

[Jory A. Pratt [:anarchy]]

Attachment: Use-C99-math-isfinite.patch

After further review we can switch to isfinite as finite has been depreciated and is no longer used on modern implementations

Comment 3

[Jory A. Pratt [:anarchy]]

Attachment: Use-C99-math-isfinite.patch

Sorry for the noise, I attached the wrong revision of patch

Comment 4

[James Cheng[:JamesCheng]]

Comment on attachment 8824795 [details] [diff] [review]
Use-C99-math-isfinite.patch

Review of attachment 8824795 [details] [diff] [review]:
-----------------------------------------------------------------

Look good to me. Make sure it can be compiled by all platforms.

But I'm not capable of reviewing this code.

Forward to Nathan to review.

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8824795 [details] [diff] [review]
Use-C99-math-isfinite.patch

Review of attachment 8824795 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, we can do this.  Thanks!

Comment 6

[Jory A. Pratt [:anarchy]]

Nathan what do we need to do in order to get this landed on mozilla-central?

Comment 7

[James Cheng[:JamesCheng]]

just fill the keywords with "checkin-needed", I did it and the sheriff will help to land it to inbound then central.

Thank you

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4723934741c5
Use C99 math isfinite, finite has been depreciated and all modern libc implementations use isfinite. r=froydnj

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4723934741c5