Closed
Bug 1320590
Opened 8 years ago
Closed 8 years ago
aushelper CPU microcode detection reports an error with AMD CPUs
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 53
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
Attachments
(1 file)
930 bytes,
patch
|
robert.strong.bugs
:
review+
jcristau
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
On systems with an AMD cpu the aushelper extension reports an error due to AMD cpu's not including the expected registry key that it checks.
Assignee | ||
Comment 1•8 years ago
|
||
This is a spinoff of bug 1315213
Assignee | ||
Comment 2•8 years ago
|
||
This patch was reviewed by felipc in bug 1315213 so carrying forward review
Attachment #8814748 -
Flags: review+
Pushed by rstrong@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bfee5b1a5508 remove reportError for microcode detection since AMD cpu's don't always have the registry key that is checked. r=felipc
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bfee5b1a5508
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8814748 [details] [diff] [review] patch Approval Request Comment [Feature/Bug causing the regression]: bug 1311515 [User impact if declined]: We want bug 1329692 on beta for websense detection and this patch made an extremely small change (removed a case where it reports to the error console) to the code bug 1329692 touches ( see bug 1329692 comment #58 ) [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes and it is also on aurora. [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: N/A [Is the change risky?]: No [Why is the change risky/not risky?]: This is an extremely small change where a report to the error console was removed and it has been on both Nightly and Aurora for awhile. [String changes made/needed]: None
Attachment #8814748 -
Flags: approval-mozilla-beta?
Comment 6•7 years ago
|
||
Comment on attachment 8814748 [details] [diff] [review] patch sure let's get that in beta9 to facilitate the websense uplift
Attachment #8814748 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/b5ac5fb65aba
status-firefox52:
--- → fixed
Comment 8•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr52/rev/b5ac5fb65aba
status-firefox-esr52:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•