1320590 - aushelper CPU microcode detection reports an error with AMD CPUs

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Robert Strong (they/them - no direct email)]

On systems with an AMD cpu the aushelper extension reports an error due to AMD cpu's not including the expected registry key that it checks.

Comment 1

[Robert Strong (they/them - no direct email)]

This is a spinoff of bug 1315213

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch

This patch was reviewed by felipc in bug 1315213 so carrying forward review

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfee5b1a5508
remove reportError for microcode detection since AMD cpu's don't always have the registry key that is checked. r=felipc

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bfee5b1a5508

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 8814748 [details] [diff] [review]
patch

Approval Request Comment
[Feature/Bug causing the regression]: bug 1311515
[User impact if declined]: We want bug 1329692 on beta for websense detection and this patch made an extremely small change (removed a case where it reports to the error console) to the code bug 1329692 touches ( see bug 1329692 comment #58 )
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes and it is also on aurora.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is an extremely small change where a report to the error console was removed and it has been on both Nightly and Aurora for awhile.
[String changes made/needed]: None

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8814748 [details] [diff] [review]
patch

sure let's get that in beta9 to facilitate the websense uplift

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b5ac5fb65aba

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/b5ac5fb65aba