Closed Bug 1320613 Opened 7 years ago Closed 7 years ago

Crash in conformance/extensions/webgl-draw-buffers-feedback-loop.html

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox51 --- fixed
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: vliu, Assigned: vliu)

Details

Attachments

(1 file, 2 obsolete files)

Add nullptr check for attach. r=jgilbert, ethlin
2.61 KB, patch
jgilbert
: review+
gchang
: approval-mozilla-aurora+
gchang
: approval-mozilla-beta+
Details | Diff | Splinter Review 
The crash happens when I run test on Khronos 2.0.1 webgl conformance test.
Assignee: nobody → vliu
Sorry for wrong information on Description. This test should belongs to Khronos 1.0.4 webgl conformance test.
Attached patch Add nullptr check for attach. (obsolete) — — Splinter Review 
Hi Ethan,
Could you please have a review. Really thanks
Attachment #8814773 - Flags: review?(ethlin)
Attached patch Add nullptr check for attach. (obsolete) — — Splinter Review 
Hi Ethan,
The proposed patch was as we discussed. Please have a review. Thanks.
Attachment #8815193 - Flags: review?(ethlin)
Attachment #8814773 - Attachment is obsolete: true
Attachment #8814773 - Flags: review?(ethlin)
Attachment #8815193 - Flags: review?(ethlin) → review+
Comment on attachment 8815193 [details] [diff] [review]
Add nullptr check for attach.

Hi Jeff,
Since the patch was relative to spec, could you also help me to review it? Thanks
Attachment #8815193 - Flags: review?(jgilbert)
Comment on attachment 8815193 [details] [diff] [review]
Add nullptr check for attach.

Review of attachment 8815193 [details] [diff] [review]:
-----------------------------------------------------------------

You forgot FramebufferTextureLayer.
Attachment #8815193 - Flags: review?(jgilbert) → review-
Hi Jeff,
Thanks for the review for the missing part. Could you review again for the attached atch? Thanks
Attachment #8817067 - Flags: review?(jgilbert)
Attachment #8815193 - Attachment is obsolete: true
Attachment #8817067 - Flags: review?(jgilbert) → review+
Pushed by vliu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/422dd1f29d6e
Add nullptr check for attach. r=jgilbert,
https://hg.mozilla.org/mozilla-central/rev/422dd1f29d6e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment on attachment 8817067 [details] [diff] [review]
Add nullptr check for attach. r=jgilbert, ethlin

Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:
Attachment #8817067 - Flags: approval-mozilla-beta?
Attachment #8817067 - Flags: approval-mozilla-aurora?
Comment on attachment 8817067 [details] [diff] [review]
Add nullptr check for attach. r=jgilbert, ethlin

WebGL2 related patch. Beta51+ & Aurora52+. Should be in 51 beta 8.
Attachment #8817067 - Flags: approval-mozilla-beta?
Attachment #8817067 - Flags: approval-mozilla-beta+
Attachment #8817067 - Flags: approval-mozilla-aurora?
Attachment #8817067 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.