1320620 - Crash in deqp/functional/gles3/shadertexturefunction/texturesize.html

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Vincent Liu[:vliu]]

The crash happens when I run test on Khronos 2.0.1 webgl conformance test.

Comment 1

[Vincent Liu[:vliu]]

Attachment: crash-stack.log

The crash-stack was attached.

Comment 2

[Vincent Liu[:vliu]]

More analysis from GDB, I found the textarget passed into fFramebufferTexture2D was illegal. When crash happens, textarget was 35866 (LOCAL_GL_TEXTURE_2D_ARRAY). The legal value was defined on page 205 in ES spec 3.0.3

1, height=2) + 612 at WebGLContext.cpp:2262, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x000000010534cb54 XUL`mozilla::ZeroTexImageWithClear(webgl=0x000000012af86800, gl=0x000000012a8db000, target=(mValue = 35866), tex=2, level=0, usage=0x000000012a7bc768, width=1, height=2) + 612 at WebGLContext.cpp:2262
   2259	        gl->fFramebufferTexture2D(LOCAL_GL_FRAMEBUFFER, attachPoint, target.get(), tex,
   2260	                                  level);
   2261	        if (errorScope.GetError()) {
-> 2262	            MOZ_ASSERT(false);
   2263	            return false;
   2264	        }
   2265	    }
(lldb) bt
* thread #1: tid = 0x178e3, 0x000000010534cb54 XUL`mozilla::ZeroTexImageWithClear(webgl=0x000000012af86800, gl=0x000000012a8db000, target=(mValue = 35866), tex=2, level=0, usage=0x000000012a7bc768, width=1, height=2) + 61

Comment 3

[Ethan Lin[:ethlin]]

Attachment: Bug 1320620 - GL_TEXTURE_2D_ARRAY should zero memory by TexSubImage3D.

Review commit: https://reviewboard.mozilla.org/r/97958/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97958/

Comment 4

[Kelsey Gilbert [:jgilbert]]

This looks like it's solved by the changes in bug 1305832.

Comment 5

[Kelsey Gilbert [:jgilbert]]

Please retest against Nightly.

Comment 6

[Kelsey Gilbert [:jgilbert]]

Please re-open if top-of-tree Nightly still has this crash.