Closed Bug 1320628 Opened 3 years ago Closed 3 years ago

Fix background tab crash when e10s is enabled

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 4 obsolete files)

No description provided.
Assignee: nobody → sotaro.ikeda.g
Blocks: webrender
attachment 8814799 [details] [diff] [review] fixed background tab crash when e10s is enabled. But it caused a rendering problem when a background tab becomes foreground.
LayerObserverEpoch might be related.
Summary: Fix Assert failure of GetBackendType() in TabChild → Fix background tab crash when e10s is enabled
Attachment #8814799 - Attachment is obsolete: true
Blocks: 1320864
Attachment #8815165 - Flags: review?(nical.bugzilla)
Attachment #8815165 - Flags: review?(nical.bugzilla)
Comment on attachment 8815165 [details] [diff] [review]
patch - Fix background tab crash when e10s is enabled

If we are going to add more support of AsWebRenderLayerManager(), we are going to see AsWebRenderLayerManager() and AsClientLayerManager() in a lot of places. :nical, what do you prefer to reduce them?
Attachment #8815165 - Flags: feedback?(nical.bugzilla)
Comment on attachment 8815165 [details] [diff] [review]
patch - Fix background tab crash when e10s is enabled

Review of attachment 8815165 [details] [diff] [review]:
-----------------------------------------------------------------

Could you try to expose the duplicated method into the base LayerManager class?
Attachment #8815165 - Flags: feedback?(nical.bugzilla)
Apply the comment.
Attachment #8815165 - Attachment is obsolete: true
Rebased.
Attachment #8815536 - Attachment is obsolete: true
Fix warning.
Attachment #8815538 - Attachment is obsolete: true
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/e98fd107f5a0
Fix background tab crash when e10s is enabled r=nical?
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.