1320671 - Show gzip request sizes in the network performance summary view

Status: RESOLVED DUPLICATE of bug 1168376

(DevTools :: Netmonitor, defect)

Description

[Patrick Brosset <:pbro>]

See this discussion thread: https://twitter.com/isellsoap/status/803227694460768261

STR:
- open the network monitor
- navigate to any site
- switch to the network performance view
- wait for the 2 pie charts to appear

=> Notice that the various requests sizes displayed there are after decompression. If gzip was used, the un-gzipped size is used.
In this view, we're focusing on what happened on the network, so it would make more sense to actually display the size of the what was transferred.

Comment 1

[Francesco Schwarz]

This fix would be really handy. It would also normalize behavior between browsers.

See Chrome actual transferred page weight (no cache) of the nytimes.com (5.5 MB): http://fs5.directupload.net/images/161128/lanit3ag.png

vs. Firefox summary view page weight (no cache) of the nytimes.com (7.2 MB): http://fs5.directupload.net/images/161128/gonj7ei2.png

Chrome depicts the real transferred page weight (the gziped one), Firefox does not.

Comment 2

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Bug 1320671 - Display transferred/compressed (instead of content/uncompressed) size in the network performance summary view. r?

Review commit: https://reviewboard.mozilla.org/r/96658/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96658/

Comment 3

[Ian Moody [:Kwan] (UTC+1)]

This is pretty simple to fix, but I'm wondering if the button to open performance analysis should also be changed, since now it'll disagree with the numbers in the summary.

Also if it should be indicated somehow that transferred rather than content sizes are being displayed?

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8815874 [details]
Bug 1320671 - Display transferred/compressed (instead of content/uncompressed) size in the network performance summary view. r?

Steve, could you please provide feedback for this patch? (it's just one-liner)

Thanks,
Honza

Comment 5

[Steve Chung [:steveck]]

Comment on attachment 8815874 [details]
Bug 1320671 - Display transferred/compressed (instead of content/uncompressed) size in the network performance summary view. r?

This change doesn't conflict to the performance statistic refactoring patch in bug 1308697, so it should be fine.

Comment 6

[Patrick Brosset <:pbro>]

(In reply to Ian Moody [:Kwan] from comment #3)
> This is pretty simple to fix, but I'm wondering if the button to open
> performance analysis should also be changed, since now it'll disagree with
> the numbers in the summary.
Sorry for the delay answering. I think that makes to me, but I'll let Honza make the final call and also decide whether this should be done here or in another bug.
> Also if it should be indicated somehow that transferred rather than content
> sizes are being displayed?

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: size.png

(In reply to Patrick Brosset <:pbro> from comment #6)
> (In reply to Ian Moody [:Kwan] from comment #3)
> > This is pretty simple to fix, but I'm wondering if the button to open
> > performance analysis should also be changed, since now it'll disagree with
> > the numbers in the summary.
> > Also if it should be indicated somehow that transferred rather than content
> > sizes are being displayed?
All valid points.

Here is what I think we should do:

1) The text under pie charts should display additional "Transferred size" field. See the attached mockup.

2) The button's label (for opening perf analysis) can stay's the same, but we should modify its tooltip. It should display also the transferred size.

An example of the tooltip text:
4 requests, 19,72 KB size, 3,57 KB transferred, 0,18 s

(I don't want to put the transferred size in the button's label since it would take a lot of horizontal space in the toolbar)

All should be done as part of this bug.

I am happy to do the review here, but note that I am on PTO last two weeks in December.
It's fine if anyone else wants to jump in and make things faster.

Btw. I tested your patch and using the 'transferredSize' field works well.

Thanks for working on this Ian!

Honza

Comment 8

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Bug 1320671 - Add transferred size to the network performance view. r?

Review commit: https://reviewboard.mozilla.org/r/99158/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99158/

Comment 9

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Bug 1320671 - Add total transferred size to the network perf analysis button tooltip. r?

Review commit: https://reviewboard.mozilla.org/r/99160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99160/

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

NI=me, just to make sure I get back to this if needed.

Honza