1320684 - Metadata decoding started before any data is available

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

Metadata decoding is typically initiated in RasterImage::Init:

http://searchfox.org/mozilla-central/rev/957458d8fa2328c2a760dbb30e7f1f1efa55b4d0/image/RasterImage.cpp#151

as eventually called by imgRequest::OnDataAvailable:

http://searchfox.org/mozilla-central/rev/957458d8fa2328c2a760dbb30e7f1f1efa55b4d0/image/imgRequest.cpp#1074

However the data isn't fed into the source buffer until a few lines later:

http://searchfox.org/mozilla-central/rev/957458d8fa2328c2a760dbb30e7f1f1efa55b4d0/image/imgRequest.cpp#1109

We should wait to dispatch the decoding task until there is actual data, otherwise it will probably just go to sleep as soon as it starts, and then wait to get resumed.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Start metadata decoding after first data chunk appended, v1

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ddcfe17738a8bdce4e3a4b8ba17772a2b9a22e52

Comment 2

[Timothy Nikkel (:tnikkel)]

Don't forget to land this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5186852360d6
Start metadata decoding when the first data chunk has been received. r=tnikkel

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Done! Thanks for the reminder.

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5186852360d6