1320686 - [nsLookAndFeel] Get styles for menu label, button text and combobox text colors from WidgetCache

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch

Use WidgetCache to get color for menu label, button text and
combobox text.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/810b7212a529
[nsLookAndFeel] Get styles for menu label, button text and combobox text colors from WidgetCache. r=karlt

Comment 4

[Mats Palmgren (inactive)]

It seems likely that this changeset caused:
TEST-UNEXPECTED-FAIL | valgrind-test | 24 bytes in 1 blocks are definitely lost at malloc / g_malloc / g_slice_alloc / g_list_prepend

This bug landed with a couple of other bugs, but those seem unlikely to have
caused this (and bug 1316803 was later backed out for unrelated failures
without fixing the above Valgrind error).
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=1219cdda749644daba4e836c146f8067215900d0

Comment 5

[Ryan VanderMeulen [:RyanVM]]

I backed this out, but pulsebot doesn't appear to be commenting in the bug as such.
https://hg.mozilla.org/integration/mozilla-inbound/rev/66c6b9f68e50

Comment 6

[Karl Tomlinson (:karlt)]

Just need to remove the fun:_ZN13nsLookAndFeel4InitEv line in the existing suppression
http://searchfox.org/mozilla-central/rev/d98418da69edeb1f2f8e6f3840157fae1512f89b/build/valgrind/x86_64-redhat-linux-gnu.sup#108
so that it matches the new caller
https://treeherder.mozilla.org/logviewer.html#?job_id=40069012&repo=mozilla-inbound#L24758

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: valgrind patch

Thanks, there's a patch with the updated callstack.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7fa5ee09c1a
[nsLookAndFeel] Get styles for menu label, button text and combobox text colors from WidgetCache. r=karlt

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c7fa5ee09c1a