Closed Bug 1320686 Opened 3 years ago Closed 3 years ago

[nsLookAndFeel] Get styles for menu label, button text and combobox text colors from WidgetCache

Categories

(Core :: Widget: Gtk, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

No description provided.
Attached patch patchSplinter Review
Use WidgetCache to get color for menu label, button text and
combobox text.
Attachment #8814909 - Flags: review?(karlt)
Attachment #8814909 - Flags: review?(karlt) → review+
Blocks: 1320883
Thanks!
Keywords: checkin-needed
Assignee: nobody → stransky
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/810b7212a529
[nsLookAndFeel] Get styles for menu label, button text and combobox text colors from WidgetCache. r=karlt
Keywords: checkin-needed
It seems likely that this changeset caused:
TEST-UNEXPECTED-FAIL | valgrind-test | 24 bytes in 1 blocks are definitely lost at malloc / g_malloc / g_slice_alloc / g_list_prepend

This bug landed with a couple of other bugs, but those seem unlikely to have
caused this (and bug 1316803 was later backed out for unrelated failures
without fixing the above Valgrind error).
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=1219cdda749644daba4e836c146f8067215900d0
Flags: needinfo?(stransky)
I backed this out, but pulsebot doesn't appear to be commenting in the bug as such.
https://hg.mozilla.org/integration/mozilla-inbound/rev/66c6b9f68e50
Attached patch valgrind patchSplinter Review
Thanks, there's a patch with the updated callstack.
Flags: needinfo?(stransky)
Attachment #8816102 - Flags: review?(karlt)
Attachment #8816102 - Flags: review?(karlt) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7fa5ee09c1a
[nsLookAndFeel] Get styles for menu label, button text and combobox text colors from WidgetCache. r=karlt
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c7fa5ee09c1a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Depends on: 1365556
You need to log in before you can comment on or make changes to this bug.