Closed
Bug 1320686
Opened 8 years ago
Closed 8 years ago
[nsLookAndFeel] Get styles for menu label, button text and combobox text colors from WidgetCache
Categories
(Core :: Widget: Gtk, defect)
Core
Widget: Gtk
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: stransky, Assigned: stransky)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files)
|
5.62 KB,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
|
924 bytes,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
Use WidgetCache to get color for menu label, button text and combobox text.
Attachment #8814909 -
Flags: review?(karlt)
|
||
Updated•8 years ago
|
Attachment #8814909 -
Flags: review?(karlt) → review+
|
||
Updated•8 years ago
|
Assignee: nobody → stransky
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/810b7212a529 [nsLookAndFeel] Get styles for menu label, button text and combobox text colors from WidgetCache. r=karlt
Keywords: checkin-needed
|
||
Comment 4•8 years ago
|
||
It seems likely that this changeset caused: TEST-UNEXPECTED-FAIL | valgrind-test | 24 bytes in 1 blocks are definitely lost at malloc / g_malloc / g_slice_alloc / g_list_prepend This bug landed with a couple of other bugs, but those seem unlikely to have caused this (and bug 1316803 was later backed out for unrelated failures without fixing the above Valgrind error). https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=1219cdda749644daba4e836c146f8067215900d0
Flags: needinfo?(stransky)
|
|
||
Comment 5•8 years ago
|
||
I backed this out, but pulsebot doesn't appear to be commenting in the bug as such. https://hg.mozilla.org/integration/mozilla-inbound/rev/66c6b9f68e50
|
|
||
Comment 6•8 years ago
|
||
Just need to remove the fun:_ZN13nsLookAndFeel4InitEv line in the existing suppression http://searchfox.org/mozilla-central/rev/d98418da69edeb1f2f8e6f3840157fae1512f89b/build/valgrind/x86_64-redhat-linux-gnu.sup#108 so that it matches the new caller https://treeherder.mozilla.org/logviewer.html#?job_id=40069012&repo=mozilla-inbound#L24758
|
|
Assignee | |
Comment 7•8 years ago
|
||
Thanks, there's a patch with the updated callstack.
Flags: needinfo?(stransky)
Attachment #8816102 -
Flags: review?(karlt)
|
|
||
Updated•8 years ago
|
Attachment #8816102 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c7fa5ee09c1a [nsLookAndFeel] Get styles for menu label, button text and combobox text colors from WidgetCache. r=karlt
Keywords: checkin-needed
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c7fa5ee09c1a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•