1320704 - Disable IntersectionObserver

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Its implementation is way too unstable to be in any tree enabled atm.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: disable the API from JS usage

https://treeherder.mozilla.org/#/jobs?repo=try&revision=09142bcf0891b7670fb65126c0db9642a280b35e

I think this should do it

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8814973 [details] [diff] [review]
disable the API from JS usage

Review of attachment 8814973 [details] [diff] [review]:
-----------------------------------------------------------------

I guess this is ok, although it kind of sucks that nsRefreshDriver still triggers work for IntersectionObserver even when there are no IntersectionObservers registered.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

well, it doesn't really do much.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef0db9c25541
Disable IntersectionObserver, r=bkelly

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8814973 [details] [diff] [review]
disable the API from JS usage

Approval Request Comment
[Feature/Bug causing the regression]: bug 1243846
[User impact if declined]: crashes
[Is this code covered by automated tests?] The patch disables tests
[Has the fix been verified in Nightly? based on stack traces this should help.
[Needs manual test from QE? If yes, steps to reproduce]: No 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: Shouldn't be
[String changes made/needed]: NA

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Happy to get the feature enabled once it is stable, but we can't have Nightlies and Aurora builds crashing for days.

Comment 7

[Tobias Schneider [:tobytailor]]

Thanks for this, was about to do the same.

Comment 8

[Kohei Yoshino [:kohei]]

Release Note Request (optional, but appreciated)
[Why is this notable]: The Intersection Observer API is listed on the 52.0a2 release notes, but it has been disabled in this bug.
[Affects Firefox for Android]: Yes
[Suggested wording]: Just remove the item to avoid any confusion.
[Links (documentation, blog post, etc)]:

Comment 9

[Gary [:streetwolf52]]

Running inbound with this patch and it appears to have fixed the crashes with Bug 1317415

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8814973 [details] [diff] [review]
disable the API from JS usage

Fix a stability issue. Aurora52+.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6ae9b39276fa

Comment 12

[Julien Cristau [:jcristau] (back August 18)]

(In reply to Kohei Yoshino [:kohei] from comment #8)
> Release Note Request (optional, but appreciated)
> [Why is this notable]: The Intersection Observer API is listed on the 52.0a2
> release notes, but it has been disabled in this bug.
> [Affects Firefox for Android]: Yes
> [Suggested wording]: Just remove the item to avoid any confusion.
> [Links (documentation, blog post, etc)]:

I've removed the item from https://www.mozilla.org/en-US/firefox/52.0a2/releasenotes/

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ef0db9c25541

Comment 14

[Nicholas Nethercote [inactive]]

Results for Nightly 20161129030222 look good. I see no crashes for any of the signatures listed in bug 1317415:

https://crash-stats.mozilla.com/search/?build_id=20161129030222&release_channel=nightly&product=Firefox&platform=Windows&date=%3E%3D2016-11-29T00%3A00%3A00.000Z&date=%3C2016-11-29T22%3A05%3A00.000Z&_sort=-date&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature

Same story in Aurora 20161129013042.

https://crash-stats.mozilla.com/search/?build_id=20161129013042&release_channel=aurora&product=Firefox&platform=Windows&date=%3E%3D2016-11-29T00%3A00%3A00.000Z&date=%3C2016-11-29T22%3A09%3A00.000Z&_sort=-date&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature

Thank you, smaug.