1320709 - selectForOfflineUse button completely fails to show the icon due to fallout from bug 348720

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Philip Chee]

([e-mail] from Bug 1160716 comment #10)
> Making this style important should fix this bug, at the expense of the
> selectForOfflineUse button which has a 4px margin for some reason. (It also
> completely fails to show the icon due to fallout from bug 348720...)

Comment 1

[Philip Chee]

Attachment: Patch to s/offline.gif/offline.png/

Affects classic theme in OSX as well so r?Stefan

Comment 2

[Stefan [:stefanh]]

I would actuall prefer not having that icon there since you really don't put icons in push buttons on Mac :-)

Comment 3

[Stefan [:stefanh]]

Comment on attachment 8814980 [details] [diff] [review]
Patch to s/offline.gif/offline.png/

># HG changeset patch
># User Philip Chee <[e-mail]>
># Parent  98b0ad0191f950efb38722735949a7e334a84c85
>Bug 1320709 - buttons with selectForOfflineUse class are missing the icon because offline.gif is now offline.png.
>(fallout from bug 348720)
>
>diff --git a/suite/themes/classic/mac/messenger/accountManage.css b/suite/themes/classic/mac/messenger/accountManage.css
>--- a/suite/themes/classic/mac/messenger/accountManage.css
>+++ b/suite/themes/classic/mac/messenger/accountManage.css
.
.
.
> .selectForOfflineUseButton {
>-  list-style-image: url("chrome://communicator/skin/icons/offline.gif");
>+  list-style-image: url("chrome://communicator/skin/icons/offline.png");
> }
> 
> .selectForOfflineUseButton > .button-box > .button-icon {
>   margin-inline-start: 4px;
>   margin-inline-end: 4px;
> }
> 
Thanks for noticing this. You can actually remove all the above style rules, it looks odd with an icon in a Mac pushbutton. r=me for everything with that fixed :-)

Comment 4

[Philip Chee]

>> .selectForOfflineUseButton {
>>-  list-style-image: url("chrome://communicator/skin/icons/offline.gif");
>>+  list-style-image: url("chrome://communicator/skin/icons/offline.png");
>> }
>> 
>> .selectForOfflineUseButton > .button-box > .button-icon {
>>   margin-inline-start: 4px;
>>   margin-inline-end: 4px;
>> }
>> 
> Thanks for noticing this. You can actually remove all the above style rules,
> it looks odd with an icon in a Mac pushbutton. r=me for everything with that
> fixed :-)

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/f86d97d3aee0
Changeset: f86d97d3aee08f99af8afb6fd47357dfe3c711c0