1320730 - Send different panel ID for activity stream panel

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Follow-up from bug 1301468.

We should send a different panel ID (not top sites) when showing the activity stream panel:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/home/HomePager.java?q=path%3AHomePager&redirect_type=single#545

Currently we manage our own session for activity stream. This might be able to replace the session; however start/stop behavior is different - so this needs some testing.

Comment 1

[Andrzej Hunt :ahunt]

Attachment: Bug 1320730 - Send different panelID for topsites when AS is enabled

Review commit: https://reviewboard.mozilla.org/r/110222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110222/

Comment 2

[Andrzej Hunt :ahunt]

The initial patch is quite hacky - I'm still figuring out how to test this properly, but AFAICT the session is ended as soon as the HomePager is hidden (via HomePager.unload(), called from BrowserApp.hideHomePager(), which should cover our restart-to-enable-AS scenario).

Comment 3

[Andrzej Hunt :ahunt]

We don't actually start a session on startup, or even when opening about:home. The first time a session is "started" is when you swipe left/right. I'll definitely try to fix that as part of this bug.

As far as I can tell we wouldn't need to send any new data, we could detect AS panel usage with:
WHERE sessions like '%homepanel.1:4becc86b-41eb-429a-a042-88fe8b5a094e%'
AND experiments like '%activity-stream%'

However there seems to be an issue with experiments not being transmitted and/or stored in our telemetry DB, so the above doesn't work (i.e. experiments is empty for all telemetry entries), so we probably will need to send a different session ID here.

Comment 4

[Andrzej Hunt :ahunt]

Attachment: Bug 1320730 - Ensure homepanel telemetry session is set when panel initially loaded

We currently only start a session when swiping between homepanels. We should also send
it when showing the homepanel normally.

Review commit: https://reviewboard.mozilla.org/r/110456/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110456/

Comment 5

[Andrzej Hunt :ahunt]

Comment on attachment 8834191 [details]
Bug 1320730 - Send different panelID for topsites when AS is enabled

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/110222/diff/1-2/

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8834606 [details]
Bug 1320730 - Ensure homepanel telemetry session is set when panel initially loaded

https://reviewboard.mozilla.org/r/110456/#review111918

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8834191 [details]
Bug 1320730 - Send different panelID for topsites when AS is enabled

https://reviewboard.mozilla.org/r/110222/#review111920

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/834561bae53c
Ensure homepanel telemetry session is set when panel initially loaded r=sebastian
https://hg.mozilla.org/integration/autoland/rev/0693364c42cc
Send different panelID for topsites when AS is enabled r=sebastian

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/834561bae53c
https://hg.mozilla.org/mozilla-central/rev/0693364c42cc