Send different panel ID for activity stream panel

RESOLVED FIXED in Firefox 54

Status

()

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sebastian, Assigned: ahunt)

Tracking

unspecified
Firefox 54
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: [MobileAS])

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Follow-up from bug 1301468.

We should send a different panel ID (not top sites) when showing the activity stream panel:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/home/HomePager.java?q=path%3AHomePager&redirect_type=single#545

Currently we manage our own session for activity stream. This might be able to replace the session; however start/stop behavior is different - so this needs some testing.
(Assignee)

Updated

2 years ago
Assignee: nobody → ahunt
Iteration: --- → 1.15
Priority: P2 → P1
Comment hidden (mozreview-request)
(Assignee)

Comment 2

2 years ago
The initial patch is quite hacky - I'm still figuring out how to test this properly, but AFAICT the session is ended as soon as the HomePager is hidden (via HomePager.unload(), called from BrowserApp.hideHomePager(), which should cover our restart-to-enable-AS scenario).
(Assignee)

Comment 3

2 years ago
We don't actually start a session on startup, or even when opening about:home. The first time a session is "started" is when you swipe left/right. I'll definitely try to fix that as part of this bug.

As far as I can tell we wouldn't need to send any new data, we could detect AS panel usage with:
WHERE sessions like '%homepanel.1:4becc86b-41eb-429a-a042-88fe8b5a094e%'
AND experiments like '%activity-stream%'

However there seems to be an issue with experiments not being transmitted and/or stored in our telemetry DB, so the above doesn't work (i.e. experiments is empty for all telemetry entries), so we probably will need to send a different session ID here.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Reporter)

Comment 6

2 years ago
mozreview-review
Comment on attachment 8834606 [details]
Bug 1320730 - Ensure homepanel telemetry session is set when panel initially loaded

https://reviewboard.mozilla.org/r/110456/#review111918
Attachment #8834606 - Flags: review?(s.kaspari) → review+
(Reporter)

Comment 7

2 years ago
mozreview-review
Comment on attachment 8834191 [details]
Bug 1320730 - Send different panelID for topsites when AS is enabled

https://reviewboard.mozilla.org/r/110222/#review111920
Attachment #8834191 - Flags: review?(s.kaspari) → review+

Comment 8

2 years ago
Pushed by ahunt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/834561bae53c
Ensure homepanel telemetry session is set when panel initially loaded r=sebastian
https://hg.mozilla.org/integration/autoland/rev/0693364c42cc
Send different panelID for topsites when AS is enabled r=sebastian

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/834561bae53c
https://hg.mozilla.org/mozilla-central/rev/0693364c42cc
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.