1320741 - Suggest `cargo target add` for when `rustc --target` configure check fails

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

In rust.configure we attempt to determine the correct `--target` argument to pass to the rust toolchain, and verify that it works. If it fails we should suggest

  rustup target add foo

As a way to install the required std library. Rustup makes this very easy for cross support and people building for Android, at least, will always run into this if they're not already familiar with using rust for that target.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1320741 - Recommend `rustup target add`.

Provide some guidance on how to resolve the common

  error: can't find crate for `std`

when cross-compiling rust code. This most commonly comes up
with the Android build.

Review commit: https://reviewboard.mozilla.org/r/96036/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96036/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8815031 [details]
Bug 1320741 - Recommend `rustup target add`.

https://reviewboard.mozilla.org/r/96036/#review96544

Comment 3

[Ralph Giles (:rillian)]

Looks like my autoland request didn't get restarted. Trying again.

Comment 4

[Ralph Giles (:rillian)]

Needs a rebase around bug 1293253.

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8815031 [details]
Bug 1320741 - Recommend `rustup target add`.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/96036/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd6aa4390d35
Recommend `rustup target add`. r=chmanchester

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cd6aa4390d35