Closed Bug 1320741 Opened 8 years ago Closed 8 years ago

Suggest `cargo target add` for when `rustc --target` configure check fails

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox53 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file)

Bug 1320741 - Recommend `rustup target add`.
58 bytes, text/x-review-board-request
chmanchester
: review+
Details 
In rust.configure we attempt to determine the correct `--target` argument to pass to the rust toolchain, and verify that it works. If it fails we should suggest

  rustup target add foo

As a way to install the required std library. Rustup makes this very easy for cross support and people building for Android, at least, will always run into this if they're not already familiar with using rust for that target.
Assignee: nobody → giles
Comment on attachment 8815031 [details]
Bug 1320741 - Recommend `rustup target add`.

https://reviewboard.mozilla.org/r/96036/#review96544
Attachment #8815031 - Flags: review?(cmanchester) → review+
Looks like my autoland request didn't get restarted. Trying again.
Needs a rebase around bug 1293253.
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd6aa4390d35
Recommend `rustup target add`. r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/cd6aa4390d35
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: