1320762 - compare-mozconfigs checks fail on Linux & OSX

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

On Linux (caused by bug 1278445):

$ ./mach test build
 0:01.08 /home/mshal/mozilla-central-git/build/compare-mozconfig/compare-mozconfigs-wrapper.py
 0:01.19 ERROR:__main__:found in /home/mshal/mozilla-central-git/browser/config/mozconfigs/linux64/beta but not in /home/mshal/mozilla-central-git/browser/config/mozconfigs/linux64/nightly: MOZ_AUTOMATION_UPLOAD_SYMBOLS=${MOZ_AUTOMATION_UPLOAD_SYMBOLS-1}
 0:01.19 ERROR:root:Mozconfig check failed!
 0:01.20 TEST-PASS | /home/mshal/mozilla-central-git/build/compare-mozconfig/compare-mozconfigs-wrapper.py | TestCompareMozconfigs.test_compare_mozconfigs


On OSX (caused by bug 1183613):

$ ./mach test build
 0:02.67 /Users/mshal/mozilla-central-git/build/compare-mozconfig/compare-mozconfigs-wrapper.py
 0:03.20 WARNING:__main__:if test `uname -s` != Linux; then not in macosx-universal [u'ac_add_options --enable-update-channel=nightly', u'ac_add_options --with-branding=browser/branding/nightly', u'ac_add_options --enable-profiling', u'mk_add_options CLIENT_PY_ARGS="--hg-options=\'--verbose --time\' --hgtool=../tools/buildfarm/utils/hgtool.py --skip-chatzilla --skip-comm --skip-inspector --tinderbox-print"', u'mk_add_options MOZ_MAKE_FLAGS="-j4"', u'if test "${MOZ_UPDATE_CHANNEL}" = "nightly"; then', u'ac_add_options --with-macbundlename-prefix=Firefox', u'fi', u'mk_add_options MOZ_MAKE_FLAGS="-j12"', u'ac_add_options --with-ccache', u'. "$topsrcdir/build/mozconfig.cache"', u'ac_add_options --disable-install-strip', u'ac_add_options --enable-instruments', u'ac_add_options --enable-dtrace']!
 0:03.20 ERROR:__main__:found in /Users/mshal/mozilla-central-git/browser/config/mozconfigs/macosx-universal/nightly but not in /Users/mshal/mozilla-central-git/browser/config/mozconfigs/macosx-universal/beta: if test `uname -s` != Linux; then
 0:03.20 ERROR:root:Mozconfig check failed!
 0:03.20 TEST-PASS | /Users/mshal/mozilla-central-git/build/compare-mozconfig/compare-mozconfigs-wrapper.py | TestCompareMozconfigs.test_compare_mozconfigs

Comment 1

[Michael Shal [:mshal]]

Attachment: Bug 1320762 - fix compare-mozconfig checks;

Review commit: https://reviewboard.mozilla.org/r/96448/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96448/

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 8815573 [details]
Bug 1320762 - fix compare-mozconfig checks;

https://reviewboard.mozilla.org/r/96448/#review96668

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fe1c7f17e68
fix compare-mozconfig checks; r=rail

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/f9278a331057
fix compare-mozconfig checks; r=rail

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f9278a331057