Add telemetry for adding a page to the home screen from the AS context menu

RESOLVED FIXED in Firefox 53

Status

()

Firefox for Android
General
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: sebastian, Assigned: ahunt)

Tracking

unspecified
Firefox 53
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [MobileAS])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

a year ago
It looks like we don't send telemetry for the old homepanels either, so I might try to add that too.

Existing telemetry covers:
- urlbar context menu: "add_to_launcher"
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#1376
- context menu from bookmark confirmation snackbar: "contextmenu_add_to_launcher"
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/delegates/BookmarkStateChangeDelegate.java#184
- HomeScreenPrompt: "home_screen_promotion"
Assignee: nobody → ahunt
Status: NEW → ASSIGNED
Iteration: --- → 1.10
Priority: P2 → P1
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Reporter)

Comment 4

a year ago
mozreview-review
Comment on attachment 8815821 [details]
Bug 1320879 - Pre: add telemetry for HomeFragment->context menu->add to homescreen

https://reviewboard.mozilla.org/r/96606/#review96822

Note that this code will be triggered form "Menu -> Page -> Add to home screen" too. So it's not only the *context* menu. But other probes do not seem to make a distinction either.
Attachment #8815821 - Flags: review?(s.kaspari) → review+
(Reporter)

Comment 5

a year ago
mozreview-review
Comment on attachment 8815822 [details]
Bug 1320879 - Add telemetry for AS context menu "add to homescreen"

https://reviewboard.mozilla.org/r/96608/#review96824

I added this to the list of AS probes that I created:
https://gist.github.com/pocmo/95fac9656d9dcf7aae970f86f754b779

I want to keep track of all the probes so that we can later verify that we get data for all of them. At some point it might make sense to move this list to the wiki.

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/menu/ActivityStreamContextMenu.java:173
(Diff revision 1)
>                  break;
>  
>              case R.id.add_homescreen:
>                  GeckoAppShell.createShortcut(title, url);
> +
> +                Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.CONTEXT_MENU, "as_add_to_launcher");

Just wondering whether Event.SAVE might make more sense here (and in the previous commit of course). That's what we use for bookmarking.
Attachment #8815822 - Flags: review?(s.kaspari) → review+
(Assignee)

Comment 6

a year ago
mozreview-review-reply
Comment on attachment 8815822 [details]
Bug 1320879 - Add telemetry for AS context menu "add to homescreen"

https://reviewboard.mozilla.org/r/96608/#review96824

> Just wondering whether Event.SAVE might make more sense here (and in the previous commit of course). That's what we use for bookmarking.

All the existing add-to-homescreen telemetry also used ACTION, I'm guessing it's better to stay consistent with that - but I'm not the biggest expert on telemetry either?

Comment 7

a year ago
Pushed by ahunt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bff33db767e0
Pre: add telemetry for HomeFragment->context menu->add to homescreen r=sebastian
https://hg.mozilla.org/integration/autoland/rev/4ebaaf148e69
Add telemetry for AS context menu "add to homescreen" r=sebastian

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bff33db767e0
https://hg.mozilla.org/mozilla-central/rev/4ebaaf148e69
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

Updated

a year ago
Blocks: 1311095
Iteration: 1.10 → 1.11
You need to log in before you can comment on or make changes to this bug.