1320879 - Add telemetry for adding a page to the home screen from the AS context menu

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Comment 1

[Andrzej Hunt :ahunt]

It looks like we don't send telemetry for the old homepanels either, so I might try to add that too.

Existing telemetry covers:
- urlbar context menu: "add_to_launcher"
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#1376
- context menu from bookmark confirmation snackbar: "contextmenu_add_to_launcher"
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/delegates/BookmarkStateChangeDelegate.java#184
- HomeScreenPrompt: "home_screen_promotion"

Comment 2

[Andrzej Hunt :ahunt]

Attachment: Bug 1320879 - Pre: add telemetry for HomeFragment->context menu->add to homescreen

Review commit: https://reviewboard.mozilla.org/r/96606/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96606/

Comment 3

[Andrzej Hunt :ahunt]

Attachment: Bug 1320879 - Add telemetry for AS context menu "add to homescreen"

Review commit: https://reviewboard.mozilla.org/r/96608/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96608/

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8815821 [details]
Bug 1320879 - Pre: add telemetry for HomeFragment->context menu->add to homescreen

https://reviewboard.mozilla.org/r/96606/#review96822

Note that this code will be triggered form "Menu -> Page -> Add to home screen" too. So it's not only the *context* menu. But other probes do not seem to make a distinction either.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8815822 [details]
Bug 1320879 - Add telemetry for AS context menu "add to homescreen"

https://reviewboard.mozilla.org/r/96608/#review96824

I added this to the list of AS probes that I created:
https://gist.github.com/pocmo/95fac9656d9dcf7aae970f86f754b779

I want to keep track of all the probes so that we can later verify that we get data for all of them. At some point it might make sense to move this list to the wiki.

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/menu/ActivityStreamContextMenu.java:173
(Diff revision 1)
>                  break;
>  
>              case R.id.add_homescreen:
>                  GeckoAppShell.createShortcut(title, url);
> +
> +                Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.CONTEXT_MENU, "as_add_to_launcher");

Just wondering whether Event.SAVE might make more sense here (and in the previous commit of course). That's what we use for bookmarking.

Comment 6

[Andrzej Hunt :ahunt]

Comment on attachment 8815822 [details]
Bug 1320879 - Add telemetry for AS context menu "add to homescreen"

https://reviewboard.mozilla.org/r/96608/#review96824

> Just wondering whether Event.SAVE might make more sense here (and in the previous commit of course). That's what we use for bookmarking.

All the existing add-to-homescreen telemetry also used ACTION, I'm guessing it's better to stay consistent with that - but I'm not the biggest expert on telemetry either?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bff33db767e0
Pre: add telemetry for HomeFragment->context menu->add to homescreen r=sebastian
https://hg.mozilla.org/integration/autoland/rev/4ebaaf148e69
Add telemetry for AS context menu "add to homescreen" r=sebastian

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bff33db767e0
https://hg.mozilla.org/mozilla-central/rev/4ebaaf148e69