1320928 - Differences in the machine_platform schema between environments

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

--- vagrant.sql	2016-11-25 17:22:53.439965200 +0000
+++ prod.sql	2016-11-25 17:31:49.775087600 +0000
...
 --
 -- Table structure for table `machine_platform`
 --
 
 DROP TABLE IF EXISTS `machine_platform`;
 /*!40101 SET @saved_cs_client     = @@character_set_client */;
 /*!40101 SET character_set_client = utf8 */;
 CREATE TABLE `machine_platform` (
   `id` int(11) NOT NULL AUTO_INCREMENT,
   `os_name` varchar(25) COLLATE utf8_bin NOT NULL,
   `platform` varchar(100) COLLATE utf8_bin NOT NULL,
-  `architecture` varchar(25) COLLATE utf8_bin NOT NULL,
+  `architecture` varchar(25) COLLATE utf8_bin DEFAULT NULL,
   PRIMARY KEY (`id`),
   UNIQUE KEY `<INDEX_NAME>` (`os_name`,`platform`,`architecture`),
   KEY `<INDEX_NAME>` (`os_name`),
   KEY `<INDEX_NAME>` (`platform`),
   KEY `<INDEX_NAME>` (`architecture`)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin;
 /*!40101 SET character_set_client = @saved_cs_client */;

Comment 1

[Ed Morley [:emorley]]

Cameron, does this (and the similar in bug 1304338) look correct to you (to run against stage/prod/prototype)?

ALTER TABLE treeherder.machine_platform MODIFY `architecture` varchar(25) NOT NULL;

Comment 2

[Cameron Dawson [:camd]]

Yep, lgtm.  :)

Comment 3

[Ed Morley [:emorley]]

Applied to prod+stage+dev:

Before:

CREATE TABLE `machine_platform` (
  `id` int(11) NOT NULL AUTO_INCREMENT,
  `os_name` varchar(25) COLLATE utf8_bin NOT NULL,
  `platform` varchar(100) COLLATE utf8_bin NOT NULL,
  `architecture` varchar(25) COLLATE utf8_bin DEFAULT NULL,
  PRIMARY KEY (`id`),
  UNIQUE KEY `machine_platform_os_name_7e14dcfeb6cb81b1_uniq` (`os_name`,`platform`,`architecture`),
  KEY `idx_os_name` (`os_name`),
  KEY `idx_platform` (`platform`),
  KEY `idx_architecture` (`architecture`)
) ENGINE=InnoDB AUTO_INCREMENT=251 DEFAULT CHARSET=utf8 COLLATE=utf8_bin

After:

CREATE TABLE `machine_platform` (
  `id` int(11) NOT NULL AUTO_INCREMENT,
  `os_name` varchar(25) COLLATE utf8_bin NOT NULL,
  `platform` varchar(100) COLLATE utf8_bin NOT NULL,
  `architecture` varchar(25) COLLATE utf8_bin NOT NULL,
  PRIMARY KEY (`id`),
  UNIQUE KEY `machine_platform_os_name_7e14dcfeb6cb81b1_uniq` (`os_name`,`platform`,`architecture`),
  KEY `idx_os_name` (`os_name`),
  KEY `idx_platform` (`platform`),
  KEY `idx_architecture` (`architecture`)
) ENGINE=InnoDB AUTO_INCREMENT=251 DEFAULT CHARSET=utf8 COLLATE=utf8_bin