1320932 - Typo in $NSS_DISABLE_LIBPKIX check in tests/ssl/ssl.sh

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[Daiki Ueno [:ueno]]

Attachment: typo-fix.patch

Hubert noticed that, after bug 1227795, running ssl.sh causes a syntax error in shell script:

  ./ssl.sh: line 1100: [: -nz: unary operator expected

I suppose it is a typo of -z?

Comment 1

[Kai Engert [:KaiE:]]

Comment on attachment 8815242 [details] [diff] [review]
typo-fix.patch

I think you're right.
r=kaie

Comment 2

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/projects/nss/rev/a6330db0f50e

Comment 3

[Kai Engert [:KaiE:]]

That hasn't worked, it triggered new failures.

But instead of a failure with the "ssl.sh" test, we get a new failure with the "chains.sh" test:


chains.sh: Verifying certificate(s)  PayPalEE.cert with flags -d AllDB -pp      -o OID.2.16.840.1.114412.1.1 
vfychain -d AllDB -pp -vv      -o OID.2.16.840.1.114412.1.1  /home/worker/nss/tests/libpkix/certs/PayPalEE.cert 
Chain is bad!
PROBLEM WITH THE CERT CHAIN:
CERT 0. PayPalEE :
  ERROR -8181: Peer's Certificate has expired.
Returned value is 1, expected result is pass
chains.sh: #4883: RealCerts: Verifying certificate(s)  PayPalEE.cert with flags -d AllDB -pp      -o OID.2.16.840.1.114412.1.1  - FAILED


This test calls vfychain with option "-pp" which will cause it to use API CERT_PKIXVerifyCert, which is available only when building with the libpkix library enabled.

The test scripts should be changed to skip any tests with "vfychain -pp" when libpkix is disabled.

Comment 4

[Kai Engert [:KaiE:]]

backed out until we have a better fix:
https://hg.mozilla.org/projects/nss/rev/5e7b5e3d301d

Comment 5

[Kai Engert [:KaiE:]]

I was wrong.

The reason for the test failure is: The "real world paypal certificate", that is checked in to NSS and that we are using during our tests, has expired today. I'll fix that with bug 1323978.

That means, we can reland the patch from this bug.

Comment 6

[Kai Engert [:KaiE:]]

Relanded:
https://hg.mozilla.org/projects/nss/rev/76a36e78b9f7