Add telemetry to AS context menu for add/remove bookmark

RESOLVED FIXED in Firefox 53

Status

()

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sebastian, Assigned: ahunt)

Tracking

unspecified
Firefox 53
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [MobileAS])

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Updated

2 years ago
Priority: -- → P2
Whiteboard: [MobileAS]
(Assignee)

Updated

2 years ago
Assignee: nobody → ahunt
Iteration: --- → 1.10
Priority: P2 → P1
Comment hidden (mozreview-request)
(Reporter)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8815834 [details]
Bug 1321008 - Add telemetry for AS context menu bookmark/unbookmark

https://reviewboard.mozilla.org/r/96616/#review97988

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/menu/ActivityStreamContextMenu.java:177
(Diff revision 1)
> +                            telemetryEvent = TelemetryContract.Event.SAVE;
> +                            telemetryExtra = "as_bookmark";

Shouldn't we here also check whether it's a reader mode url and send a different telemetry probe so that the telemetry for save/unsave is somewhat synchronous?
Attachment #8815834 - Flags: review?(s.kaspari) → review+
(Assignee)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8815834 [details]
Bug 1321008 - Add telemetry for AS context menu bookmark/unbookmark

https://reviewboard.mozilla.org/r/96616/#review98394

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/menu/ActivityStreamContextMenu.java:177
(Diff revision 1)
> +                            telemetryEvent = TelemetryContract.Event.SAVE;
> +                            telemetryExtra = "as_bookmark";

I don't think that's possible in this case - any pages showing in activity stream won't be reader view URLs (i.e. we remove about:reader? before storing in history, so AS won't know that it originally was an about:reader page).

Comment 4

2 years ago
Pushed by ahunt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e573f18c8dc7
Add telemetry for AS context menu bookmark/unbookmark r=sebastian

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e573f18c8dc7
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

Updated

2 years ago
Blocks: 1311095

Updated

2 years ago
Iteration: 1.10 → 1.11
You need to log in before you can comment on or make changes to this bug.