1321008 - Add telemetry to AS context menu for add/remove bookmark

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Comment 1

[Andrzej Hunt :ahunt]

Attachment: Bug 1321008 - Add telemetry for AS context menu bookmark/unbookmark

Review commit: https://reviewboard.mozilla.org/r/96616/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96616/

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8815834 [details]
Bug 1321008 - Add telemetry for AS context menu bookmark/unbookmark

https://reviewboard.mozilla.org/r/96616/#review97988

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/menu/ActivityStreamContextMenu.java:177
(Diff revision 1)
> +                            telemetryEvent = TelemetryContract.Event.SAVE;
> +                            telemetryExtra = "as_bookmark";

Shouldn't we here also check whether it's a reader mode url and send a different telemetry probe so that the telemetry for save/unsave is somewhat synchronous?

Comment 3

[Andrzej Hunt :ahunt]

Comment on attachment 8815834 [details]
Bug 1321008 - Add telemetry for AS context menu bookmark/unbookmark

https://reviewboard.mozilla.org/r/96616/#review98394

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/menu/ActivityStreamContextMenu.java:177
(Diff revision 1)
> +                            telemetryEvent = TelemetryContract.Event.SAVE;
> +                            telemetryExtra = "as_bookmark";

I don't think that's possible in this case - any pages showing in activity stream won't be reader view URLs (i.e. we remove about:reader? before storing in history, so AS won't know that it originally was an about:reader page).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e573f18c8dc7
Add telemetry for AS context menu bookmark/unbookmark r=sebastian

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e573f18c8dc7