1321120 - TypeError: is not iterable

Status: RESOLVED INVALID

(Firefox :: Sync, defect)

Description

[Ethan Glasser-Camp (:glasserc)]

Attachment: error-sync-1480462961608.txt

Full message: TypeError:  is not iterable
Full stack: AddonInstall.prototype.onStopRequest/<@resource://gre/modules/addons/XPIProvider.jsm:5987:1
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:940:21
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:750:11
waitForSyncCallback@resource://services-common/async.js:98:7
makeSpinningCallback/callback.wait@resource://services-common/async.js:152:27
create@resource://gre/modules/services-sync/engines/addons.js:299:19
Store.prototype.applyIncoming@resource://services-sync/engines.js:339:7
applyIncoming@resource://gre/modules/services-sync/engines/addons.js:281:5
Store.prototype.applyIncomingBatch@resource://services-sync/engines.js:303:9
doApplyBatch@resource://services-sync/engines.js:1002:32
SyncEngine.prototype._processIncoming/newitems.recordHandler@resource://services-sync/engines.js:1128:9
set recordHandler/this._onProgress@resource://services-sync/record.js:623:9
Channel_onDataAvail@resource://services-sync/resource.js:539:7
waitForSyncCallback@resource://services-common/async.js:98:7
Res__request@resource://services-sync/resource.js:383:14
Res_get@resource://services-sync/resource.js:410:12
SyncEngine.prototype._processIncoming@resource://services-sync/engines.js:1135:18
SyncEngine.prototype._sync@resource://services-sync/engines.js:1555:7
WrappedNotify@resource://services-sync/util.js:165:21
Engine.prototype.sync@resource://services-sync/engines.js:670:5
_syncEngine@resource://services-sync/stages/enginesync.js:213:7
sync@resource://services-sync/stages/enginesync.js:163:15
onNotify@resource://gre/modules/services-sync/service.js:1278:7
WrappedNotify@resource://services-sync/util.js:165:21
WrappedLock@resource://services-sync/util.js:120:16
_lockedSync@resource://gre/modules/services-sync/service.js:1268:12
sync/<@resource://gre/modules/services-sync/service.js:1260:14
WrappedCatch@resource://services-sync/util.js:94:16
sync@resource://gre/modules/services-sync/service.js:1248:5

*************************

Based on the logs I assume this means that a WebExtension that I wrote, https://github.com/glasserc/you-re-not-so-special, wasn't synced successfully, although I don't know why.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

This WFM on 53 - I installed that addon on one profile, then in a second the sync logs show:

> 1480466361563	Sync.Collection	DEBUG	mesg: GET success 200 https://sync-367-us-west-2.sync.services.mozilla.com/1.5/51378304/storage/addons?newer=1478500774.17&full=1&limit=1000
> 1480466361563	Sync.Collection	DEBUG	GET success 200 https://sync-367-us-west-2.sync.services.mozilla.com/1.5/51378304/storage/addons?newer=1478500774.17&full=1&limit=1000
> 1480466362339	Sync.AddonUtils	INFO	Found 1/1 add-ons during repository search.
> 1480466362340	Sync.AddonUtils	INFO	Add-on "[e-mail]" is able to be installed
> 1480466362342	Sync.AddonUtils	INFO	Trying to install add-on from search result: [e-mail]
> 1480466362342	Sync.AddonUtils	DEBUG	Obtaining install for [e-mail]
> 1480466362344	Sync.AddonUtils	INFO	Installing [e-mail]
> 1480466363935	Sync.AddonUtils	INFO	Setting syncGUID of You're Not So Special: {bc085ffe-064d-4e3d-945d-c30252d082a0}
...
> 1480466364066	addons.xpi	WARN	Failed to remove temporary file C:\Users\skip\AppData\Local\Temp\tmp-9mm.xpi for addon https://addons.mozilla.org/firefox/downloads/file/482125/youre_not_so_special-1.1-fx+an.xpi?src=sync: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: removeTemporaryFile :: line 5556"  data: no] Stack trace: removeTemporaryFile()@resource://gre/modules/addons/XPIProvider.jsm:5556 < startInstall/<()@resource://gre/modules/addons/XPIProvider.jsm:6038 < Handler.prototype.process()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:932 < this.PromiseWalker.walkerLoop()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813

(hrm - the above entry seems suspect, but I expect it is benign)

> 1480466364068	Sync.Store.Addons	INFO	Add-on installed: [e-mail]

Ethan, you reported this against 49, which is now old. Are you able to repro on 50 or 53?

Comment 2

[Ethan Glasser-Camp (:glasserc)]

I ended up uninstalling the add-on from another computer and was then able to sync successfully, and then reinstall it. It may have been something quirky with my specific profile. Let's forget about it for now.