Closed Bug 1321196 Opened 3 years ago Closed 3 years ago

Refactor the block-media-element feature - part 2.

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: kaku, Assigned: kaku)

References

Details

Attachments

(2 files)

Further decompose the HTMLMediaElement::IsAllowedToPlay() and AudioChannelAgentCallback::IsAllowedToPlay() so that we can have all the spec. code in the HTMLMediaElement::PlayInternal() and only policy code in the HTMLMediaElement::Play().
Blocks: 1244768
Depends on: 1302350, 1309162
Assignee: nobody → kaku
Comment on attachment 8815654 [details]
Bug 1321196 part 2 - rework the IsAllowedToPlay policy;

https://reviewboard.mozilla.org/r/96504/#review96720
Attachment #8815654 - Flags: review?(jwwang) → review+
Comment on attachment 8815653 [details]
Bug 1321196 part 1 - typo correction;

https://reviewboard.mozilla.org/r/96502/#review96728
Attachment #8815653 - Flags: review?(alwu) → review+
Comment on attachment 8815654 [details]
Bug 1321196 part 2 - rework the IsAllowedToPlay policy;

https://reviewboard.mozilla.org/r/96504/#review96732
Attachment #8815654 - Flags: review?(alwu) → review+
Try looks good, thanks for the reviews!
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e972bb041a4e
part 1 - typo correction; r=alwu
https://hg.mozilla.org/integration/autoland/rev/fcabe39c665f
part 2 - rework the IsAllowedToPlay policy; r=alwu,jwwang
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e972bb041a4e
https://hg.mozilla.org/mozilla-central/rev/fcabe39c665f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.